test: refactor test_runner tests to change default reporter #54547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
|
Note: this PR is part of #54548 |
RedYetiDev
added
the
test_runner
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54547 +/- ##
==========================================
- Coverage 87.33% 87.32% -0.01%
==========================================
Files 649 649
Lines 182622 182623 +1
Branches 35037 35044 +7
==========================================
- Hits 159494 159483 -11
- Misses 16393 16401 +8
- Partials 6735 6739 +4 |
cjihrig
force-pushed
the
reporter-tests
branch
from
efd6176
to
c6c92c2
Compare
|
|
github-actions
bot
removed
the
request-ci
It's also failing in a few other places, like https://ci.nodejs.org/job/node-test-binary-windows-js-suites/29545/testReport/ |
benjamingr
approved these changes
Aug 25, 2024
|
Issue has been resolved, would you mind rebasing 🙏 I will try to follow up with the CI |
jasnell
approved these changes
Aug 26, 2024
This commit updates the test runner tests in order to switch the default reporter from tap to spec. This commit can be backported, while changing the default reporter cannot. Refs: nodejs#54540
cjihrig
force-pushed
the
reporter-tests
branch
from
c6c92c2
to
9b3fab5
Compare
github-actions
bot
removed
the
request-ci
cjihrig
added
request-ci
github-actions
bot
removed
the
request-ci
MoLow
approved these changes
Aug 26, 2024
jakecastelli
approved these changes
Aug 27, 2024
jakecastelli
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3d5357a |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
This commit updates the test runner tests in order to switch the default reporter from tap to spec. This commit can be backported, while changing the default reporter cannot. Refs: #54540 PR-URL: #54547 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
This commit updates the test runner tests in order to switch the default reporter from tap to spec. This commit can be backported, while changing the default reporter cannot. Refs: #54540 PR-URL: #54547 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Merged
targos
added
the
dont-land-on-v20.x
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
This commit updates the test runner tests in order to switch the default reporter from tap to spec. This commit can be backported, while changing the default reporter cannot. Refs: nodejs#54540 PR-URL: nodejs#54547 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the test runner tests in order to switch the default reporter from tap to spec. This commit can be backported, while changing the default reporter cannot.
This will also allow us to more slowly migrate the tests off of using the TAP reporter in some places. We should still test the TAP reporter though. In some cases the TAP reporter is beneficial for testing purposes - for example, verifying that tests are output with the correct test number ordering.
Refs: #54540