-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v22.8.0 proposal #54560
v22.8.0 proposal #54560
Commits on Aug 24, 2024
-
doc: reserve ABI 130 for Electron 33
Backport-PR-URL: #54455 PR-URL: #54383 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 83b5efe - Browse repository at this point
Copy the full SHA 83b5efeView commit details
Commits on Aug 25, 2024
-
doc: add esm examples to node:https
PR-URL: #54399 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2541991 - Browse repository at this point
Copy the full SHA 2541991View commit details -
doc, meta: add missing
,
toBUILDING.md
PR-URL: #54409 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6ccbd32 - Browse repository at this point
Copy the full SHA 6ccbd32View commit details -
meta: run coverage-windows when
vcbuild.bat
updatedPR-URL: #54412 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c4996c1 - Browse repository at this point
Copy the full SHA c4996c1View commit details -
src: move more crypto code to ncrypto
PR-URL: #54320 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 909c532 - Browse repository at this point
Copy the full SHA 909c532View commit details -
test_runner: finish build phase before running tests
This commit updates the test runner to wait for suites to finish building before starting any tests. This is necessary when test filtering is enabled, as suites may transition from filtered to not filtered depending on what is inside of them. Fixes: #54084 Fixes: #54154 PR-URL: #54423 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cbe30a0 - Browse repository at this point
Copy the full SHA cbe30a0View commit details -
src: improve
buffer.transcode
performancePR-URL: #54153 Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3a74c40 - Browse repository at this point
Copy the full SHA 3a74c40View commit details -
test_runner: make
mock.module
'sspecifier
consistent withimport()
The previous implementation was trying to follow both `require` and `import` conventions. It is not practical to try to follow both, and aligning with `import()` seems to be what makes the most sense. PR-URL: #54416 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for 1c29e74 - Browse repository at this point
Copy the full SHA 1c29e74View commit details -
module: add sourceURL magic comment hinting generated source
Source map is not necessary in strip-only mode. However, to map the source file in debuggers to the original TypeScript source, add a sourceURL magic comment to hint that it is a generated source. PR-URL: #54402 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 336496b - Browse repository at this point
Copy the full SHA 336496bView commit details -
test_runner: account for newline in source maps
This commit updates the source mapping logic in the test runner to account for newline characters that are not included in line length calculations. Co-authored-by: Simon Chan <1330321+yume-chan@users.noreply.github.com> Fixes: #54240 PR-URL: #54444 Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for 45b0250 - Browse repository at this point
Copy the full SHA 45b0250View commit details -
test_runner: defer inheriting hooks until run()
This commit updates the way the test runner computes inherited hooks. Instead of computing them when the Test/Suite is constructed, they are now computed just prior to running the Test/Suite. The reason is because when multiple test files are run in the same process, it is possible for the inherited hooks to change as more files are loaded. PR-URL: #53927 Fixes: #51548 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 858b583 - Browse repository at this point
Copy the full SHA 858b583View commit details
Commits on Aug 30, 2024
-
test_runner: support running tests in process
This commit introduces a new --experimental-test-isolation flag that, when set to 'none', causes the test runner to execute all tests in the same process. By default, this is the main test runner process, but if watch mode is enabled, it spawns a separate process that runs all of the tests. The default value of the new flag is 'process', which uses the existing behavior of running each test file in its own child process. It is worth noting that when the isolation mode is 'none', globals and all other top level logic (such as top level before() and after() hooks) is shared among all files. Co-authored-by: Moshe Atlow <moshe@atlow.co.il> PR-URL: #53927 Fixes: #51548 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 97fa075 - Browse repository at this point
Copy the full SHA 97fa075View commit details -
PR-URL: #54433 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3caf29e - Browse repository at this point
Copy the full SHA 3caf29eView commit details -
deps: sqlite: fix Windows compilation
This is equivalent to the following upstream change: https://sqlite.org/src/info/6c103aee6f146869 Original commit message: Change constant expressions to pre-computed constants, because apparently MSVC on ARM requires that. [forum:/forumpost/4feb1685cced0a8e|Forum thread 4feb1685cced0a8e]. FossilOrigin-Name: 6c103aee6f146869a3e0c48694592f2e4c6b57ecdb4450f46e762c38b4e686f1 PR-URL: #54433 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a5ce241 - Browse repository at this point
Copy the full SHA a5ce241View commit details -
test_runner: refactor
mock_loader
PR-URL: #54223 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0cf78aa - Browse repository at this point
Copy the full SHA 0cf78aaView commit details -
test: prevent V8 from writing into the system's tmpdir
Refs: nodejs/build#3864 PR-URL: #54395 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for b0ed8db - Browse repository at this point
Copy the full SHA b0ed8dbView commit details -
PR-URL: #54462 Fixes: nodejs/amaro#49 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
Configuration menu - View commit details
-
Copy full SHA for da6c61d - Browse repository at this point
Copy the full SHA da6c61dView commit details -
PR-URL: #54456 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9c70920 - Browse repository at this point
Copy the full SHA 9c70920View commit details -
meta: add more labels to dep-updaters
PR-URL: #54454 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0d7171d - Browse repository at this point
Copy the full SHA 0d7171dView commit details -
doc: fix capitalization in module.md
PR-URL: #54488 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 61affd7 - Browse repository at this point
Copy the full SHA 61affd7View commit details -
PR-URL: #54473 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b584356 - Browse repository at this point
Copy the full SHA b584356View commit details -
stream: change stream to use index instead of
for...of
PR-URL: #54474 Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fffc300 - Browse repository at this point
Copy the full SHA fffc300View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e01bdc - Browse repository at this point
Copy the full SHA 1e01bdcView commit details -
src: remove cached data tag from snapshot metadata
This only served as a preemptive check, but serializing this in the snapshot would make it unreproducible on different hardware. In the current cached data version tag, the V8 version can already be checked as part of the existing Node.js version check. The V8 flags aren't necessarily important for snapshot/code cache mismatches (only a small subset are), and the CPU features currently don't matter, so doing an exact match is stricter than necessary. Removing the check to help making the snapshot more reproducible on different hardware. PR-URL: #54122 Refs: nodejs/build#3043 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for eef3030 - Browse repository at this point
Copy the full SHA eef3030View commit details -
meta: remind users to use a supported version in bug reports
PR-URL: #54481 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b5a23c9 - Browse repository at this point
Copy the full SHA b5a23c9View commit details -
test_runner: add support for coverage thresholds
Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com> PR-URL: #54429 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d4310fe - Browse repository at this point
Copy the full SHA d4310feView commit details -
build: update required python version to 3.8
Co-Authored-By: Jim B <d3x0r@users.noreply.github.com> PR-URL: #54358 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 71fdf96 - Browse repository at this point
Copy the full SHA 71fdf96View commit details -
test: add tests for runner coverage with different stdout column widths
PR-URL: #54494 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8a4f8a9 - Browse repository at this point
Copy the full SHA 8a4f8a9View commit details -
build: don't clean obj.target directory if it doesn't exist
This can happen to ninja builds, which would then throw an error instead of being a noop if the command is executed. PR-URL: #54337 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 467ac3a - Browse repository at this point
Copy the full SHA 467ac3aView commit details -
fs: refactor handleTimestampsAndMode to remove redundant call
Refactored the `handleTimestampsAndMode` function to eliminate the redundant `setDestTimestampsAndMode` call. This simplifies the function by ensuring that `setDestTimestampsAndMode` is only called once after any necessary modifications to file writability. PR-URL: #54369 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fc08a9b - Browse repository at this point
Copy the full SHA fc08a9bView commit details -
typings: provide internal types for wasi bindings
PR-URL: #54119 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 16d4c43 - Browse repository at this point
Copy the full SHA 16d4c43View commit details -
doc: update websocket flag description to reflect stable API status
doc: update websocket flag description to reflect stable API status doc: revert syntax detection description PR-URL: #54482 Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1800a58 - Browse repository at this point
Copy the full SHA 1800a58View commit details -
test: fix improper path to URL conversion
PR-URL: #54509 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 02d664b - Browse repository at this point
Copy the full SHA 02d664bView commit details -
PR-URL: #54404 Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Configuration menu - View commit details
-
Copy full SHA for 8a4b26f - Browse repository at this point
Copy the full SHA 8a4b26fView commit details -
PR-URL: #54520 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for 290f6ce - Browse repository at this point
Copy the full SHA 290f6ceView commit details -
sqlite: return results with null prototype
These objects are dictionaries, and a query can return columns with special names like `__proto__` (which would be ignored without this change). Also construct the object by passing vectors of properties for better performance and improve error handling by using `MaybeLocal`. PR-URL: #54350 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 72c554a - Browse repository at this point
Copy the full SHA 72c554aView commit details -
benchmark: fix benchmark for file path and URL conversion
PR-URL: #54190 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 94985df - Browse repository at this point
Copy the full SHA 94985dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66ae9f4 - Browse repository at this point
Copy the full SHA 66ae9f4View commit details -
src: change SetEncodedValue to return Maybe<void>
With recent versions of V8, it is not necessary to use Maybe<bool> anymore. This changes SetEncodedValue to return Maybe<void> instead. PR-URL: #54443 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7d9e994 - Browse repository at this point
Copy the full SHA 7d9e994View commit details -
test: force spec reporter in test-runner-watch-mode.mjs
In the CI this test generates TAP output that can confuse the Python test runner. Avoid the problem by not outputting TAP at from the spawned child process. Fixes: #54535 PR-URL: #54538 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b5eb24c - Browse repository at this point
Copy the full SHA b5eb24cView commit details -
src: use better return types in KVStore
- Use `v8::Maybe<void>` instead of `v8::Maybe<bool>` and handle error from `AssignFromObject`. - An empty `v8::Maybe` is supposed to be returned when an exception is pending. Use `std::optional` instead to indicate a missing value in `Get(key)`. PR-URL: #54539 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4578e94 - Browse repository at this point
Copy the full SHA 4578e94View commit details -
src: return
v8::Object
from error constructorsIt's more specific than `v8::Value`. PR-URL: #54541 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4938188 - Browse repository at this point
Copy the full SHA 4938188View commit details -
src: handle errors correctly in
permission.cc
Return an empty `MaybeLocal` to indicate that an exception is pending. PR-URL: #54541 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1ff3f63 - Browse repository at this point
Copy the full SHA 1ff3f63View commit details -
tools: remove unused python files
PR-URL: #53928 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3879814 - Browse repository at this point
Copy the full SHA 3879814View commit details -
test: refactor test_runner tests to change default reporter
This commit updates the test runner tests in order to switch the default reporter from tap to spec. This commit can be backported, while changing the default reporter cannot. Refs: #54540 PR-URL: #54547 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 846e2b2 - Browse repository at this point
Copy the full SHA 846e2b2View commit details -
deps: update c-ares to v1.33.1
PR-URL: #54549 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for fe56949 - Browse repository at this point
Copy the full SHA fe56949View commit details -
buffer: allow invalid encoding in from
Looks like a bug to me but the change should probably done in a semver majpr. PR-URL: #54533 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for afd8c1e - Browse repository at this point
Copy the full SHA afd8c1eView commit details -
src: remove redundant AESCipherMode
For each supported variant of AES, we already have OpenSSL's associated NID, so we can simply retrieve the block cipher mode of operation from the NID. PR-URL: #54438 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e6e1f4e - Browse repository at this point
Copy the full SHA e6e1f4eView commit details -
buffer: truncate instead of throw when writing beyond buffer
Fixes: #54523 Fixes: #54518 PR-URL: #54524 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ac178b0 - Browse repository at this point
Copy the full SHA ac178b0View commit details -
node-api: remove RefBase and CallbackWrapper
PR-URL: #53590 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 3cd10a3 - Browse repository at this point
Copy the full SHA 3cd10a3View commit details -
src: move more crypto_dh.cc code to ncrypto
Update deps/ncrypto/ncrypto.cc PR-URL: #54459 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 101e299 - Browse repository at this point
Copy the full SHA 101e299View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cf6457 - Browse repository at this point
Copy the full SHA 3cf6457View commit details -
PR-URL: #54442 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8ffdd1e - Browse repository at this point
Copy the full SHA 8ffdd1eView commit details -
doc: add note about shasum generation failure
PR-URL: #54487 Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fc57bea - Browse repository at this point
Copy the full SHA fc57beaView commit details -
lib: fix emit warning for debuglog.time when disabled
PR-URL: #54275 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for a9ce2b6 - Browse repository at this point
Copy the full SHA a9ce2b6View commit details -
doc: support collaborators - talk amplification
- document that we support collaborators by amplifying their talks Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #54508 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c3dc83b - Browse repository at this point
Copy the full SHA c3dc83bView commit details -
deps: backport ICU-22787 to fix ClangCL on Windows
- Floating patch for ICU 75.x ICU Bug: https://unicode-org.atlassian.net/browse/ICU-22787 Backport of: unicode-org/icu#3023 PR-URL: #54502 Reviewed-By: Steven R Loomis <srl295@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 33a6b3c - Browse repository at this point
Copy the full SHA 33a6b3cView commit details -
doc: fix information about including coverage files
PR-URL: #54527 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c499913 - Browse repository at this point
Copy the full SHA c499913View commit details -
test: fix embedding test for Windows
PR-URL: #53659 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 72345de - Browse repository at this point
Copy the full SHA 72345deView commit details -
PR-URL: #54562 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for 7fd033f - Browse repository at this point
Copy the full SHA 7fd033fView commit details -
Revert "net: validate host name for server listen"
This reverts commit 52322aa. PR-URL: #54554 Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 04f83b5 - Browse repository at this point
Copy the full SHA 04f83b5View commit details -
lib: respect terminal capabilities on styleText
This PR changes styleText API to respect terminal capabilities and environment variables such as NO_COLOR, NODE_DISABLE_COLORS, and FORCE_COLOR. PR-URL: #54389 Fixes: #54365 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4a664b5 - Browse repository at this point
Copy the full SHA 4a664b5View commit details -
src: add JS APIs for compile cache and NODE_DISABLE_COMPILE_CACHE
This patch adds the following API for tools to enable compile cache dynamically and query its status. - module.enableCompileCache(cacheDir) - module.getCompileCacheDir() In addition this adds a NODE_DISABLE_COMPILE_CACHE environment variable to disable the code cache enabled by the APIs as an escape hatch to avoid unexpected/undesired effects of the compile cache (e.g. less precise test coverage). When the module.enableCompileCache() method is invoked without a specified directory, Node.js will use the value of the NODE_COMPILE_CACHE environment variable if it's set, or defaults to `path.join(os.tmpdir(), 'node-compile-cache')` otherwise. Therefore it's recommended for tools to call this method without specifying the directory to allow overrides. PR-URL: #54501 Fixes: #53639 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4baf463 - Browse repository at this point
Copy the full SHA 4baf463View commit details -
test: refactor test-abortcontroller to use node:test
Starting the long process of refactoring our own tests to use the node:test module and mocks. PR-URL: #54574 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 64442fc - Browse repository at this point
Copy the full SHA 64442fcView commit details -
test: update test-aborted-util to use node:test
PR-URL: #54578 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dbbc790 - Browse repository at this point
Copy the full SHA dbbc790View commit details -
test: move a couple of tests over to using node:test
PR-URL: #54582 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c10aff6 - Browse repository at this point
Copy the full SHA c10aff6View commit details -
deps: V8: cherry-pick e74d0f437fcd
Original commit message: [api] add v8::Isolate::GetDefaultLocale() This allows embedders to query the default locale used by Intl APIs. This information is already available to user land via Intl?.Collator().resolvedOptions().locale, the issue with this is that it's a lot slower and requires dynamic access to Intl API, which is subject to patching and prototype pollution so it's not as reliable for embedders than having a V8 API to query the default locale directly. Refs: #54279 Change-Id: I5a1823993c9ae79f8f61f54c6464daf882a09ba3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5772938 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#95678} Refs: v8/v8@e74d0f4 PR-URL: #54279 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b00c087 - Browse repository at this point
Copy the full SHA b00c087View commit details -
src: use v8::Isolate::GetDefaultLocale() to compute navigator.language
Using the Intl API to get the default locale slows down the startup significantly. This patch uses a new v8 API to get the default locale directly. PR-URL: #54279 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f8cbbc6 - Browse repository at this point
Copy the full SHA f8cbbc6View commit details -
doc: fix module compile cache description
PR-URL: #54625 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 80e5150 - Browse repository at this point
Copy the full SHA 80e5150View commit details -
doc: add getHeapStatistics() property descriptions
PR-URL: #54584 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 825d933 - Browse repository at this point
Copy the full SHA 825d933View commit details -
src: disable fast methods for
buffer.write
It should resolve the regressions while we work on fixing them. Refs: #54521 PR-URL: #54565 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e071651 - Browse repository at this point
Copy the full SHA e071651View commit details -
test: merge ongc and gcutil into gc.js
PR-URL: #54355 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a0be95e - Browse repository at this point
Copy the full SHA a0be95eView commit details -
test_runner: ensure test watcher picks up new test files
PR-URL: #54225 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a4bebf8 - Browse repository at this point
Copy the full SHA a4bebf8View commit details -
vm: introduce vanilla contexts via vm.constants.DONT_CONTEXTIFY
This implements a flavor of vm.createContext() and friends that creates a context without contextifying its global object. This is suitable when users want to freeze the context (impossible when the global is contextified i.e. has interceptors installed) or speed up the global access if they don't need the interceptor behavior. ```js const vm = require('node:vm'); const context = vm.createContext(vm.constants.DONT_CONTEXTIFY); // In contexts with contextified global objects, this is false. // In vanilla contexts this is true. console.log(vm.runInContext('globalThis', context) === context); // In contexts with contextified global objects, this would throw, // but in vanilla contexts freezing the global object works. vm.runInContext('Object.freeze(globalThis);', context); // In contexts with contextified global objects, freezing throws // and won't be effective. In vanilla contexts, freezing works // and prevents scripts from accidentally leaking globals. try { vm.runInContext('globalThis.foo = 1; foo;', context); } catch(e) { console.log(e); // Uncaught ReferenceError: foo is not defined } console.log(context.Array); // [Function: Array] ``` PR-URL: #54394 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for db80eac - Browse repository at this point
Copy the full SHA db80eacView commit details -
deps: update nghttp2 to 1.63.0
PR-URL: #54589 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for 73604cf - Browse repository at this point
Copy the full SHA 73604cfView commit details -
test,crypto: update WebCryptoAPI WPT
Refs: #54572 Refs: #54468 PR-URL: #54593 Refs: #54572 Refs: #54468 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5ee234a - Browse repository at this point
Copy the full SHA 5ee234aView commit details -
test: update test-assert to use node:test
PR-URL: #54585 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c74f2ae - Browse repository at this point
Copy the full SHA c74f2aeView commit details -
test: update test-assert-typedarray-deepequal to use node:test
PR-URL: #54585 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9f1ce73 - Browse repository at this point
Copy the full SHA 9f1ce73View commit details
Commits on Sep 1, 2024
-
doc: fix typo in styleText description
PR-URL: #54616 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bf82448 - Browse repository at this point
Copy the full SHA bf82448View commit details -
test: update test-abortsignal-cloneable to use node:test
PR-URL: #54581 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bc976cf - Browse repository at this point
Copy the full SHA bc976cfView commit details -
test: increase key size for ca2-cert.pem
Refs: #44498 Refs: #53382 Key sizes were increased to 2048 in PR 44498 including the configuration file for the generation of ca2-cert.pem. However, it seems like updating ca2-cert.pem and related files themselves were missed as they were not updated in the PR and the ca2-cert.pem reported as being associated with a 1024 bit key. I believe that was the cause of some of the failures mentioned in #53382 as OpenSSL 3.2 increased the default security level from 1 to 2 and that would mean that certificates associated with keys of 1024 bits would no longer be accepted. This PR updates the key size for ca2-cert.pem. It was not necessary to change the config, only run the generation for the ca2-cert.pem and related files. Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #54599 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for edbecf5 - Browse repository at this point
Copy the full SHA edbecf5View commit details -
test: run V8 Fast API tests in release mode too
Only keep the call count assertions under `common.isDebug`. PR-URL: #54570 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 522d5a3 - Browse repository at this point
Copy the full SHA 522d5a3View commit details -
vm: return all own names and symbols in property enumerator interceptor
Property enumerator methods like `Object.getOwnPropertyNames`, `Object.getOwnPropertySymbols`, and `Object.keys` all invokes the named property enumerator interceptor. V8 will filter the result based on the invoked enumerator variant. Fix the enumerator interceptor to return all potential properties. PR-URL: #54522 Refs: jsdom/jsdom#3688 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fe5666f - Browse repository at this point
Copy the full SHA fe5666fView commit details -
src,lib: add performance.uvMetricsInfo
This commit exposes a new API to the perf_hooks.performance module. This wraps uv_metrics_info into performance.uvMetricsInfo() function. PR-URL: #54413 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 9ba75fa - Browse repository at this point
Copy the full SHA 9ba75faView commit details -
doc: add alert on REPL from TCP socket
PR-URL: #54594 Refs: https://hackerone.com/reports/2684357 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f5c5529 - Browse repository at this point
Copy the full SHA f5c5529View commit details -
doc: add support me link for anonrig
PR-URL: #54611 Refs: https://github.com/nodejs/node/blob/4f14eb15454b9f6ae7f0145947debd2c79a2a84f/doc/contributing/recognizing-contributors.md?plain=1#L23 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 68758d4 - Browse repository at this point
Copy the full SHA 68758d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76345a5 - Browse repository at this point
Copy the full SHA 76345a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4a6ef8 - Browse repository at this point
Copy the full SHA a4a6ef8View commit details -
build: reclaim disk space on macOS GHA runner
Refs: nodejs/build#3878 PR-URL: #54658 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 6f0cf35 - Browse repository at this point
Copy the full SHA 6f0cf35View commit details
Commits on Sep 3, 2024
-
2024-09-03, Version 22.8.0 (Current)
Notable changes: net: * (SEMVER-MINOR) exclude ipv6 loopback addresses from server.listen (Giovanni Bucci) #54264 src: * (SEMVER-MINOR) add JS APIs for compile cache and NODE_DISABLE_COMPILE_CACHE (Joyee Cheung) #54501 src,lib: * (SEMVER-MINOR) add performance.uvMetricsInfo (Rafael Gonzaga) #54413 test_runner: * (SEMVER-MINOR) add support for coverage thresholds (Aviv Keller) #54429 * (SEMVER-MINOR) support running tests in process (Colin Ihrig) #53927 * (SEMVER-MINOR) defer inheriting hooks until run() (Colin Ihrig) #53927 vm: * (SEMVER-MINOR) introduce vanilla contexts via vm.constants.DONT_CONTEXTIFY (Joyee Cheung) #54394 PR-URL: #54560
Configuration menu - View commit details
-
Copy full SHA for 78ee90e - Browse repository at this point
Copy the full SHA 78ee90eView commit details