-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refactor test-whatwg-webstreams-encoding
to be shorter
#54569
Conversation
@hidaviddong please remove the merge commit. |
done |
This comment was marked as outdated.
This comment was marked as outdated.
This will make diagnosing any failures harder as the stack traces will now point to the loop without an indication of which iteration of the loop failed. |
Do I need to add a stack trace? like done in #45146 |
I think that would work. |
test-whatwg-webstreams-encoding
to be shorter
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54569 +/- ##
==========================================
- Coverage 87.33% 87.31% -0.03%
==========================================
Files 649 649
Lines 182623 182755 +132
Branches 35041 35051 +10
==========================================
+ Hits 159498 159575 +77
- Misses 16400 16452 +52
- Partials 6725 6728 +3 |
This comment was marked as outdated.
This comment was marked as outdated.
I see a CI failure, but I'm not sure what caused it. Do I need to change anything? |
Landed in 291d90a |
PR-URL: #54569 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: nodejs#54569 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: nodejs#54569 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Use a
forEach
loop forassert.throws
statements, improving code readability.