Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-whatwg-webstreams-encoding to be shorter #54569

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

hidaviddong
Copy link
Contributor

Use a forEach loop for assert.throws statements, improving code readability.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 26, 2024
@lpinca
Copy link
Member

lpinca commented Aug 29, 2024

@hidaviddong please remove the merge commit.

@hidaviddong
Copy link
Contributor Author

@hidaviddong please remove the merge commit.

done

@lpinca lpinca added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2024
@nodejs-github-bot

This comment was marked as outdated.

@richardlau
Copy link
Member

Use a forEach loop for assert.throws statements, improving code readability.

This will make diagnosing any failures harder as the stack traces will now point to the loop without an indication of which iteration of the loop failed.

@hidaviddong
Copy link
Contributor Author

Use a forEach loop for assert.throws statements, improving code readability.

This will make diagnosing any failures harder as the stack traces will now point to the loop without an indication of which iteration of the loop failed.

Do I need to add a stack trace? like done in #45146

@richardlau
Copy link
Member

Use a forEach loop for assert.throws statements, improving code readability.

This will make diagnosing any failures harder as the stack traces will now point to the loop without an indication of which iteration of the loop failed.

Do I need to add a stack trace? like done in #45146

I think that would work.

@hidaviddong hidaviddong changed the title test: refactor test-whatwg-webstreams-encoding to be shorter test: refactor test-whatwg-webstreams-encoding to be shorter Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.31%. Comparing base (4ce9864) to head (9738074).
Report is 737 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54569      +/-   ##
==========================================
- Coverage   87.33%   87.31%   -0.03%     
==========================================
  Files         649      649              
  Lines      182623   182755     +132     
  Branches    35041    35051      +10     
==========================================
+ Hits       159498   159575      +77     
- Misses      16400    16452      +52     
- Partials     6725     6728       +3     

see 54 files with indirect coverage changes

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2024
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 29, 2024

@hidaviddong
Copy link
Contributor Author

I see a CI failure, but I'm not sure what caused it. Do I need to change anything?

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 8, 2024
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 19, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 19, 2024
@nodejs-github-bot nodejs-github-bot merged commit 291d90a into nodejs:main Sep 19, 2024
58 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 291d90a

targos pushed a commit that referenced this pull request Oct 4, 2024
PR-URL: #54569
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
PR-URL: nodejs#54569
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
PR-URL: nodejs#54569
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. web streams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants