Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update test-aborted-util to use node:test #54578

Closed
wants to merge 1 commit into from
Closed

test: update test-aborted-util to use node:test #54578

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Aug 26, 2024

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 26, 2024
@codecov Codecov

This comment was marked as outdated.

Sign in to view
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
cjihrig
cjihrig approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I worry that things like lazySpawn() here will make it more difficult for folks to contribute (particularly new people). If I'm writing a Node.js unit test, child_process is always available. If I also need to worry about other runtimes, how do I know which Node core modules are safe to use and which would require the lazySpawn() treatment?

@jasnell
Copy link
Member Author

jasnell commented Aug 28, 2024 •
edited
Loading

... how do I know which Node core modules are safe to use and which would require the lazySpawn() treatment?

I'd imagine that folks would write the test specifically for node.js and those of us who might need to adjust things would have the burden of updating the test or adapting the runtime to it.

Alternatively, we could move the require(...) into the test(...) and gate it with a skip condition like skip: process.getBuiltinModule('child_process') !== undefined

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 28, 2024 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/61619/ 💛

jasnell added a commit that referenced this pull request Aug 29, 2024
@jasnell
test: update test-aborted-util to use node:test
097dcfc 
PR-URL: #54578
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Aug 29, 2024

Landed in 097dcfc

@jasnell jasnell closed this Aug 29, 2024
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
@jasnell @RafaelGSS
test: update test-aborted-util to use node:test
de5c340 
PR-URL: #54578
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
@jasnell @RafaelGSS
test: update test-aborted-util to use node:test
cb7a2ba 
PR-URL: #54578
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
@jasnell @RafaelGSS
test: update test-aborted-util to use node:test
dbbc790 
PR-URL: #54578
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Aug 30, 2024
Merged
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 22, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@jasnell @louwers
test: update test-aborted-util to use node:test
0e424e7 
PR-URL: nodejs#54578
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@anonrig anonrig anonrig approved these changes

@mcollina mcollina Awaiting requested review from mcollina

Assignees
No one assigned
Labels
dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @nodejs-github-bot @anonrig @cjihrig @targos