doc: clarify expandedSQL behavior #54685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not sure what exactly the primary use case is for this function given that the Node.js API is not designed for users to manually bind parameters of prepared statements, but this at least clarifies what the function does.
nodejs-github-bot
added
doc
targos
approved these changes
Sep 1, 2024
|
Maybe the purpose is debugging? |
|
Yeah, maybe users can then copy-paste the SQL query into a different SQLite interface for debugging. I don't think there's any pre-processing besides substituting named parameters for the values. |
Yes, that's it. There is value in being able to see what SQL a prepared statement evaluates to. |
|
Ah, I assumed the SQLite developers' intention was to enable this without having to actually execute the statement, hence I was confused by the design here. But that makes sense, thank you! |
tniessen
added
author ready
|
Specifically just the use of "method" |
tniessen
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6c6a933 |
aduh95
pushed a commit
that referenced
this pull request
Sep 12, 2024
I am not sure what exactly the primary use case is for this function given that the Node.js API is not designed for users to manually bind parameters of prepared statements, but this at least clarifies what the function does. PR-URL: #54685 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
targos
added
the
dont-land-on-v20.x
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
I am not sure what exactly the primary use case is for this function given that the Node.js API is not designed for users to manually bind parameters of prepared statements, but this at least clarifies what the function does. PR-URL: nodejs#54685 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure what exactly the primary use case is for this function given that the Node.js API is not designed for users to manually bind parameters of prepared statements, but this at least clarifies what the function does.