Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: bump actions/setup-python from 5.1.1 to 5.2.0 #54691

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 1, 2024

I'm not sure if we have tooling configured to do this update automatically on a schedule, but I don't see it anywhere. (I didn't do an exhaustive search, though...). I basically copied this from a dependabot update on a fork.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 1, 2024
@targos
Copy link
Member

targos commented Sep 1, 2024

I don't know how it's configured but dependabot usually opens update PRs (maybe once a month)

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.60%. Comparing base (71b36b3) to head (30af855).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54691      +/-   ##
==========================================
- Coverage   87.61%   87.60%   -0.01%     
==========================================
  Files         650      650              
  Lines      182834   182834              
  Branches    35382    35383       +1     
==========================================
- Hits       160194   160179      -15     
- Misses      15925    15927       +2     
- Partials     6715     6728      +13     

see 35 files with indirect coverage changes

@richardlau
Copy link
Member

I'm not sure if we have tooling configured to do this update automatically on a schedule, but I don't see it anywhere. (I didn't do an exhaustive search, though...). I basically copied this from a dependabot update on a fork.

#54701

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 2, 2024
@RedYetiDev
Copy link
Member

Both this PR and the other one are in the commit-queue, shouldn't one of them be closed?

@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 3, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/54691
✔  Done loading data for nodejs/node/pull/54691
----------------------------------- PR info ------------------------------------
Title      meta: bump actions/setup-python from 5.1.1 to 5.2.0 (#54691)
Author     Rich Trott <rtrott@gmail.com> (@Trott)
Branch     Trott:bump -> nodejs:main
Labels     meta, author ready
Commits    1
 - meta: bump actions/setup-python from 5.1.1 to 5.2.0
Committers 1
 - Rich Trott <rtrott@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/54691
Fixes: https://github.com/nodejs/node/pull/54701
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54691
Fixes: https://github.com/nodejs/node/pull/54701
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 01 Sep 2024 16:02:39 GMT
   ✔  Approvals: 4
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/54691#pullrequestreview-2274449904
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/54691#pullrequestreview-2274500657
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/54691#pullrequestreview-2274692100
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54691#pullrequestreview-2276098846
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 54691
From https://github.com/nodejs/node
 * branch                  refs/pull/54691/merge -> FETCH_HEAD
✔  Fetched commits as 9e5d2b74fb22..30af855f236f
--------------------------------------------------------------------------------
[main ccf34125d1] meta: bump actions/setup-python from 5.1.1 to 5.2.0
 Author: Rich Trott <rtrott@gmail.com>
 Date: Sun Sep 1 09:00:30 2024 -0700
 13 files changed, 17 insertions(+), 17 deletions(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
meta: bump actions/setup-python from 5.1.1 to 5.2.0

PR-URL: #54691
Fixes: #54701
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

[main fe18179c28] meta: bump actions/setup-python from 5.1.1 to 5.2.0
Author: Rich Trott <rtrott@gmail.com>
Date: Sun Sep 1 09:00:30 2024 -0700
13 files changed, 17 insertions(+), 17 deletions(-)
✖ fe18179c28fe27ed6b2b1fd29386e78b7ebc3d6d
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✖ 2:7 Pull request URL must reference a comment or discussion. fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
⚠ 0:50 Title should be <= 50 columns. title-length

ℹ Please fix the commit message and try again.
Please manually ammend the commit message, by running
git commit --amend
Once commit message is fixed, finish the landing command running
git node land --continue

https://github.com/nodejs/node/actions/runs/10686630628

@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 4, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 4, 2024
@nodejs-github-bot nodejs-github-bot merged commit bb4ec34 into nodejs:main Sep 4, 2024
39 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in bb4ec34

@Trott Trott deleted the bump branch September 4, 2024 17:58
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
PR-URL: #54691
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants