zlib: remove prototype primordials usage #54695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
|
CC @nodejs/primordials @nodejs/zlib |
targos
approved these changes
Sep 1, 2024
anonrig
added
author ready
marco-ippolito
approved these changes
Sep 1, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
reviewed
Sep 1, 2024
ronag
approved these changes
Sep 1, 2024
anonrig
added
the
commit-queue-squash
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54695 +/- ##
==========================================
- Coverage 88.07% 88.07% -0.01%
==========================================
Files 652 652
Lines 183570 183566 -4
Branches 35872 35860 -12
==========================================
- Hits 161686 161681 -5
- Misses 15137 15140 +3
+ Partials 6747 6745 -2
|
This comment was marked as outdated.
This comment was marked as outdated.
ljharb
reviewed
Sep 1, 2024
This comment was marked as outdated.
This comment was marked as outdated.
ronag
approved these changes
Sep 3, 2024
jasnell
approved these changes
Sep 3, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ruyadorno
approved these changes
Sep 5, 2024
|
This PR is currently blocked from landing due to unreliable CI |
MoLow
approved these changes
Sep 9, 2024
github-actions
bot
removed
the
request-ci
anonrig
force-pushed
the
yagiz/remove-primordials-zlib
branch
from
61cd7b9 to
a77b6cb
Compare
trivikr
approved these changes
Sep 11, 2024
# Conflicts: # lib/zlib.js
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
anonrig
force-pushed
the
yagiz/remove-primordials-zlib
branch
from
a77b6cb to
3bf4e0a
Compare
anonrig
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54695 ✔ Done loading data for nodejs/node/pull/54695 ----------------------------------- PR info ------------------------------------ Title zlib: remove prototype primordials usage (#54695) Author Yagiz Nizipli <yagiz@nizipli.com> (@anonrig) Branch anonrig:yagiz/remove-primordials-zlib -> nodejs:main Labels zlib, author ready, needs-ci, needs-benchmark-ci, commit-queue-squash Commits 2 - zlib: remove prototype primordials usage - Update zlib.js Committers 1 - Yagiz Nizipli <yagiz@nizipli.com> PR-URL: https://github.com/nodejs/node/pull/54695 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54695 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - zlib: remove prototype primordials usage ⚠ - Update zlib.js ℹ This PR was created on Sun, 01 Sep 2024 16:28:21 GMT ✔ Approvals: 7 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/54695#pullrequestreview-2274458346 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/54695#pullrequestreview-2274459245 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/54695#pullrequestreview-2277737863 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54695#pullrequestreview-2277787527 ✔ - Ruy Adorno (@ruyadorno) (TSC): https://github.com/nodejs/node/pull/54695#pullrequestreview-2283877520 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/54695#pullrequestreview-2289797393 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/54695#pullrequestreview-2295411895 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-09-18T23:57:25Z: https://ci.nodejs.org/job/node-test-pull-request/62543/ - Querying data for job/node-test-pull-request/62543/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10933395608 |
KhafraDev
approved these changes
Sep 19, 2024
anonrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in c42d846 |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
# Conflicts: # lib/zlib.js PR-URL: #54695 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
# Conflicts: # lib/zlib.js PR-URL: nodejs#54695 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
marco-ippolito
added
the
dont-land-on-v20.x
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
# Conflicts: # lib/zlib.js PR-URL: nodejs#54695 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of the primordials work done by @aduh95 and others, let's remove the prototypal primordials from
node:zlib