deps: update cjs-module-lexer to 1.4.0 #54713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
dependencies
|
Review requested:
|
nodejs-github-bot
added
lib / src
|
The issue turned out to be the Windows line endings here. Apparently I'm the only one that develops on Windows! Pushed up a commit that should resolve the problem. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54713 +/- ##
=======================================
Coverage 87.61% 87.61%
=======================================
Files 650 650
Lines 182835 182829 -6
Branches 35382 35386 +4
=======================================
- Hits 160185 160181 -4
- Misses 15925 15930 +5
+ Partials 6725 6718 -7 |
richardlau
added
request-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Sep 5, 2024
lpinca
approved these changes
Sep 6, 2024
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 01bf4a1 |
aduh95
pushed a commit
that referenced
this pull request
Sep 12, 2024
PR-URL: #54713 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This comment was marked as duplicate.
This comment was marked as duplicate.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated update of cjs-module-lexer to 1.4.0.