Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: convert signals to array before validation #54714

Merged
merged 1 commit into from
Sep 6, 2024
Merged

lib: convert signals to array before validation #54714

merged 1 commit into from
Sep 6, 2024

Conversation

jazelly
Copy link
Contributor

@jazelly jazelly commented Sep 2, 2024

Fixes: #54674

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 2, 2024 •
edited by jakecastelli
Loading

Review requested:

  • @nodejs/crypto
  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Sep 2, 2024
@jazelly jazelly changed the title abort_controller: convert signals to array before validation lib: convert signals to array before validation Sep 2, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 87.60%. Comparing base (981c701) to head (80b16d1).
Report is 47 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/webidl.js 88.31% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54714      +/-   ##
==========================================
- Coverage   87.61%   87.60%   -0.01%     
==========================================
  Files         650      650              
  Lines      182835   182881      +46     
  Branches    35382    35397      +15     
==========================================
+ Hits       160185   160218      +33     
- Misses      15925    15930       +5     
- Partials     6725     6733       +8
Files with missing lines Coverage Δ
lib/internal/abort_controller.js 97.90% <100.00%> (+0.03%) ⬆️
lib/internal/crypto/webidl.js 98.29% <100.00%> (+0.65%) ⬆️
lib/internal/webidl.js 94.57% <88.31%> (-1.30%) ⬇️

... and 33 files with indirect coverage changes

@WontonSam

This comment was marked as duplicate.

Sign in to view
mcollina
mcollina reviewed Sep 2, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this fix any wpts?

@KhafraDev
Copy link
Member

the WPTs don't usually test webidl validations because implementations are assumed to be using them for the dozens of specs they implement

mcollina
mcollina approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mertcanaltin
mertcanaltin approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@mertcanaltin mertcanaltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

KhafraDev
KhafraDev reviewed Sep 3, 2024
View reviewed changes
lib/internal/webidl.js Outdated Show resolved Hide resolved
@jazelly @jakecastelli
lib: convert signals to array before validation
80b16d1 
Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
@jakecastelli jakecastelli added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. web-standards Issues and PRs related to Web APIs labels Sep 3, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jakecastelli
Copy link
Contributor

jakecastelli commented Sep 3, 2024 •
edited
Loading

osx failure on CI due to java.io.IOException: No space left on device (6h ago) however I also observed nodejs/jenkins-alerts#2785 (10h ago) mentioned The machine has now enough disk space 🙌

Other failures are most likely flaky tests, rerunning

update: rerun works on osx, seems the no space issue has been resolved.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jakecastelli jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61897/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 4, 2024 •
edited by jakecastelli
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/61905/ 💛

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 6, 2024
@nodejs-github-bot nodejs-github-bot merged commit 973144b into nodejs:main Sep 6, 2024
66 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 973144b

aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@jazelly @jakecastelli @aduh95
lib: convert signals to array before validation
fc78ced 
Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #54714
Fixes: #54674
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva left review comments

@jakecastelli jakecastelli jakecastelli left review comments

@KhafraDev KhafraDev KhafraDev approved these changes

@mcollina mcollina mcollina approved these changes

@benjamingr benjamingr benjamingr approved these changes

@aymen94 aymen94 aymen94 approved these changes

@aduh95 aduh95 aduh95 approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@mertcanaltin mertcanaltin mertcanaltin approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. web-standards Issues and PRs related to Web APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AbortSignal.any does not work on all sequences