Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: add some assert benchmarks #54734

Closed
wants to merge 4 commits into from
Closed

benchmark: add some assert benchmarks #54734

wants to merge 4 commits into from

Conversation

RafaelGSS
Copy link
Member

I'm increasing the benchmark coverage of some modules. Some important assert methods were missing.

@RafaelGSS RafaelGSS added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. benchmark Issues and PRs related to the benchmark subsystem. labels Sep 3, 2024
@nodejs-github-bot nodejs-github-bot added the assert Issues and PRs related to the assert subsystem. label Sep 3, 2024
@mertcanaltin
Copy link
Member

Hello, is it okay to use this? const assert = require('node:assert');

mertcanaltin
mertcanaltin reviewed Sep 4, 2024
View reviewed changes
benchmark/assert/match.js
'use strict';

const common = require('../common.js');
const assert = require('assert');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const assert = require('assert');
const assert = require('node:assert');

mertcanaltin
mertcanaltin reviewed Sep 4, 2024
View reviewed changes
benchmark/assert/rejects.js
'use strict';

const common = require('../common.js');
const assert = require('assert');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const assert = require('assert');
const assert = require('node:assert');

benchmark/assert/strictequal.js
'use strict';

const common = require('../common.js');
const assert = require('assert');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const assert = require('assert');
const assert = require('node:assert');

benchmark/assert/throws.js
'use strict';

const common = require('../common.js');
const assert = require('assert');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const assert = require('assert');
const assert = require('node:assert');

@RafaelGSS RafaelGSS added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 5, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2024
@nodejs-github-bot
Copy link
Collaborator

Landed in 65b4fb8...248d5e0

nodejs-github-bot pushed a commit that referenced this pull request Sep 5, 2024
@RafaelGSS @nodejs-github-bot
benchmark: add strictEqual and notStrictEqual bench
688c885 
PR-URL: #54734
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
nodejs-github-bot pushed a commit that referenced this pull request Sep 5, 2024
@RafaelGSS @nodejs-github-bot
benchmark: add throws and doesNotThrow bench
0b283c2 
PR-URL: #54734
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
nodejs-github-bot pushed a commit that referenced this pull request Sep 5, 2024
@RafaelGSS @nodejs-github-bot
benchmark: add rejects and doesNotReject bench
b262381 
PR-URL: #54734
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
nodejs-github-bot pushed a commit that referenced this pull request Sep 5, 2024
@RafaelGSS @nodejs-github-bot
benchmark: add match and doesNotMatch bench
248d5e0 
PR-URL: #54734
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@RafaelGSS @aduh95
benchmark: add strictEqual and notStrictEqual bench
456a1fe 
PR-URL: #54734
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@RafaelGSS @aduh95
benchmark: add throws and doesNotThrow bench
af7689e 
PR-URL: #54734
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@RafaelGSS @aduh95
benchmark: add rejects and doesNotReject bench
2844180 
PR-URL: #54734
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@RafaelGSS @aduh95
benchmark: add match and doesNotMatch bench
0601644 
PR-URL: #54734
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@mertcanaltin mertcanaltin mertcanaltin approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RafaelGSS @mertcanaltin @nodejs-github-bot @Trott @atlowChemi