Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf_hooks: add missing type argument to getEntriesByName #54767

Merged
merged 1 commit into from
Sep 24, 2024
Merged

perf_hooks: add missing type argument to getEntriesByName #54767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/internal/perf/performance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,16 @@ class Performance extends EventTarget {
return filterBufferMapByNameAndType();
}

getEntriesByName(name) {
getEntriesByName(name, type = undefined) {
validateInternalField(this, kPerformanceBrand, 'Performance');
if (arguments.length === 0) {
throw new ERR_MISSING_ARGS('name');
}
name = `${name}`;
return filterBufferMapByNameAndType(name, undefined);
if (type !== undefined) {
type = `${type}`;
}
return filterBufferMapByNameAndType(name, type);
}

getEntriesByType(type) {
Expand Down
6 changes: 6 additions & 0 deletions test/parallel/test-performance-timeline.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ await setTimeout(50);
performance.measure('a', 'one');
const entriesByName = performance.getEntriesByName('a');
assert.deepStrictEqual(entriesByName.map((x) => x.entryType), ['measure', 'mark', 'measure', 'mark']);
const marksByName = performance.getEntriesByName('a', 'mark');
assert.deepStrictEqual(marksByName.map((x) => x.entryType), ['mark', 'mark']);
const measuresByName = performance.getEntriesByName('a', 'measure');
assert.deepStrictEqual(measuresByName.map((x) => x.entryType), ['measure', 'measure']);
const invalidTypeEntriesByName = performance.getEntriesByName('a', null);
assert.strictEqual(invalidTypeEntriesByName.length, 0);

// getEntriesBy[Name|Type](undefined)
performance.mark(undefined);
Expand Down
Loading