test: add missing await #54828
Merged
test: add missing await #54828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing `await` in `test/parallel/test-inspector-async-stack-traces-promise-then.js`.
nodejs-github-bot
added
needs-ci
jakecastelli
approved these changes
Sep 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54828 +/- ##
=======================================
Coverage 87.61% 87.62%
=======================================
Files 651 651
Lines 183343 183343
Branches 35442 35446 +4
=======================================
+ Hits 160643 160652 +9
+ Misses 15959 15957 -2
+ Partials 6741 6734 -7 |
jasnell
approved these changes
Sep 7, 2024
github-actions
bot
removed
the
request-ci
trivikr
approved these changes
Sep 8, 2024
MoLow
approved these changes
Sep 8, 2024
richardlau
approved these changes
Sep 12, 2024
|
@lpinca thanks for your work on making the tests more reliable! |
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a7b0369 |
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 16, 2024
Add missing `await` in `test/parallel/test-inspector-async-stack-traces-promise-then.js`. PR-URL: #54828 Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 16, 2024
Add missing `await` in `test/parallel/test-inspector-async-stack-traces-promise-then.js`. PR-URL: #54828 Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 17, 2024
Add missing `await` in `test/parallel/test-inspector-async-stack-traces-promise-then.js`. PR-URL: #54828 Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing
awaitintest/parallel/test-inspector-async-stack-traces-promise-then.js.