Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: detect only tests when isolation is off #54832

Merged
merged 2 commits into from
Sep 12, 2024
Merged

test_runner: detect only tests when isolation is off #54832

merged 2 commits into from
Sep 12, 2024

Commits on Sep 12, 2024

  1. test_runner: apply filtering when tests begin 

    This commit updates the way filtering is applied to tests and
suites. After this change, filters are applied just before the
test/suite is started. The results are the same, but this allows
us to eventually move away from the --test-only flag except
when process level isolation is used.

PR-URL: nodejs#54832
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    @cjihrig
    cjihrig committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e78fd8c View commit details
    Browse the repository at this point in the history

  2. test_runner: detect only tests when isolation is off 

    This commit updates the way the test runner processes 'only'
tests when process-based test isolation is disabled. The
--test-only flag is no longer necessary in this scenario. The
test runner will automatically detect 'only' tests and apply the
appropriate filtering.

PR-URL: nodejs#54832
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    @cjihrig
    cjihrig committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f5f67ae View commit details
    Browse the repository at this point in the history