Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove test-http-server-request-timeouts-mixed from parallel.st… #54841

Closed

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Sep 7, 2024

Test was moved to sequential a while back. It's still flaky in sequential, but shouldn't be listed in parallel.status any longer.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 7, 2024
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.90%. Comparing base (e1e312d) to head (0742120).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54841      +/-   ##
==========================================
- Coverage   87.90%   87.90%   -0.01%     
==========================================
  Files         651      651              
  Lines      183343   183343              
  Branches    35710    35713       +3     
==========================================
- Hits       161165   161159       -6     
+ Misses      15466    15463       -3     
- Partials     6712     6721       +9     

see 40 files with indirect coverage changes

@lpinca lpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 8, 2024
Copy link
Contributor

github-actions bot commented Sep 8, 2024

Fast-track has been requested by @lpinca. Please 👍 to approve.

@jasnell jasnell added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 8, 2024
Test was moved to sequential a while back.
@jasnell jasnell force-pushed the remove-test-from-parallel-status branch from 64a323c to 0742120 Compare September 8, 2024 19:06
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2024
@nodejs-github-bot
Copy link
Collaborator

jasnell added a commit that referenced this pull request Sep 10, 2024
Test was moved to sequential a while back.

PR-URL: #54841
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Sep 10, 2024

Landed in 22ea302

@jasnell jasnell closed this Sep 10, 2024
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
Test was moved to sequential a while back.

PR-URL: #54841
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95 pushed a commit that referenced this pull request Sep 13, 2024
Test was moved to sequential a while back.

PR-URL: #54841
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95 pushed a commit that referenced this pull request Sep 13, 2024
Test was moved to sequential a while back.

PR-URL: #54841
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants