-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v8,tools: expose experimental wasm revectorize feature #54896
Open
yolanda15
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
yolanda15:enable_revec
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
build
Issues and PRs related to build files or the CI.
needs-ci
PRs that need a full CI run.
tools
Issues and PRs related to the tools directory.
v8 engine
Issues and PRs related to the V8 dependency.
labels
Sep 12, 2024
targos
reviewed
Sep 12, 2024
yolanda15
force-pushed
the
enable_revec
branch
from
September 13, 2024 02:55
07ba285
to
f5381ba
Compare
targos
approved these changes
Sep 13, 2024
@targos Could you help me merge this PL? I seem not authorized and it's already one week passed. Thank you in advance! |
gengjiawen
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 20, 2024
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Sep 20, 2024
Commit Queue failed- Loading data for nodejs/node/pull/54896 ✔ Done loading data for nodejs/node/pull/54896 ----------------------------------- PR info ------------------------------------ Title v8,tools: expose experimental wasm revectorize feature (#54896) Author Yolanda-Chen <yolanda.chen@intel.com> (@yolanda15, first-time contributor) Branch yolanda15:enable_revec -> nodejs:main Labels build, v8 engine, tools, needs-ci Commits 1 - v8,tools: expose experimental wasm revectorize feature Committers 1 - Yolanda Chen <yolanda.chen@intel.com> PR-URL: https://github.com/nodejs/node/pull/54896 Reviewed-By: Michaël Zasso <targos@protonmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54896 Reviewed-By: Michaël Zasso <targos@protonmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 12 Sep 2024 07:48:42 GMT ✔ Approvals: 1 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/54896#pullrequestreview-2303482481 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10952384360 |
yolanda15
force-pushed
the
enable_revec
branch
from
September 20, 2024 04:33
f5381ba
to
8234dfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Issues and PRs related to build files or the CI.
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
needs-ci
PRs that need a full CI run.
tools
Issues and PRs related to the tools directory.
v8 engine
Issues and PRs related to the V8 dependency.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wasm simd256 revectorization feature is enabled by default when v8_enable_webassembly is true on x64 target in V8. At runtime it will be enabled through flag --experimental-wasm-revectorize.
This PR adds the build configuration in Node to enable this feature and make it explicitly accessible through the same runtime flag for x64 build.