src: move evp stuff to ncrypto #54911

jasnell · 2024-09-12T20:48:46Z

More incremental moving of crypto stuff to ncrypto ... there's a lot to so I'm chunking it up into smaller, more easily reviewed pieces.

nodejs-github-bot · 2024-09-12T20:48:51Z

Review requested:

@nodejs/crypto
@nodejs/security-wg

nodejs-github-bot · 2024-09-12T20:49:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62376/

codecov · 2024-09-12T22:52:34Z

Codecov Report

Attention: Patch coverage is 70.86093% with 44 lines in your changes missing coverage. Please review.

Project coverage is 88.24%. Comparing base (0c8c107) to head (3f5d3ca).
Report is 54 commits behind head on main.

Files with missing lines	Patch %	Lines
src/crypto/crypto_ec.cc	61.22%	8 Missing and 11 partials ⚠️
src/crypto/crypto_keys.cc	71.21%	7 Missing and 12 partials ⚠️
src/crypto/crypto_common.cc	75.00%	0 Missing and 3 partials ⚠️
src/crypto/crypto_sig.cc	83.33%	0 Missing and 2 partials ⚠️
src/crypto/crypto_dh.cc	66.66%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #54911   +/-   ##
=======================================
  Coverage   88.23%   88.24%           
=======================================
  Files         652      652           
  Lines      183856   183816   -40     
  Branches    35856    35841   -15     
=======================================
- Hits       162229   162208   -21     
+ Misses      14903    14888   -15     
+ Partials     6724     6720    -4

Files with missing lines	Coverage Δ
src/crypto/crypto_cipher.cc	`73.40% <100.00%> (ø)`
src/crypto/crypto_dsa.cc	`58.97% <100.00%> (ø)`
src/crypto/crypto_keys.h	`56.86% <100.00%> (ø)`
src/crypto/crypto_rsa.cc	`63.78% <100.00%> (+0.27%)`	⬆️
src/crypto/crypto_dh.cc	`61.53% <66.66%> (ø)`
src/crypto/crypto_sig.cc	`71.64% <83.33%> (+0.13%)`	⬆️
src/crypto/crypto_common.cc	`52.75% <75.00%> (-0.41%)`	⬇️
src/crypto/crypto_ec.cc	`67.05% <61.22%> (+0.49%)`	⬆️
src/crypto/crypto_keys.cc	`73.07% <71.21%> (+0.86%)`	⬆️

... and 34 files with indirect coverage changes

anonrig · 2024-09-12T21:38:01Z

src/crypto/crypto_ec.cc

+      if (!error.IsEmpty()) env->isolate()->ThrowException(error);
+      return false;


You can just return at this point, since 857 is returning true.

anonrig · 2024-09-13T01:24:14Z

src/crypto/crypto_sig.cc

-    default:
-      return false;
-  }
+  return key.id() == EVP_PKEY_ED25519 || key.id() == EVP_PKEY_ED448;


all of these functions can be constexpr

Let's separately go through and make these kinds of improvements in one of the follow up PRs

panva · 2024-09-14T15:38:31Z

@jasnell I feel that all these "move * to ncrypto" PRs that move stuff into a flat file structure are a step back in terms of the crypto subsystem refactoring that you've done in #35093. Do you plan on introducing a structure to it?

It refactors the Node.js src crypto internals so that they are more maintainable and organized.

jasnell · 2024-09-20T21:56:01Z

Do you plan on introducing a structure to it?

Yes, once things are moved over to ncrypto, the plan is to restructure ncrypto to makes things cleaner and break things up. It's a bit cumbersome right now given the sheer size of the task and trying to break it down into digestable chunks... but I promise it will come out improved when we're done.

nodejs-github-bot · 2024-09-22T16:14:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62675/

PR-URL: #54911 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

jasnell · 2024-09-23T11:21:18Z

Landed in c4681d5

PR-URL: #54911 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: nodejs#54911 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

nodejs/node#54911

PR-URL: nodejs#54911 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

nodejs/node#54911

jasnell requested review from mcollina, anonrig and tniessen September 12, 2024 20:48

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 12, 2024

jasnell force-pushed the move-evp-stuff-to-ncrypto branch from caf2971 to 143b9f4 Compare September 12, 2024 21:29

anonrig approved these changes Sep 13, 2024

View reviewed changes

avivkeller added crypto Issues and PRs related to the crypto subsystem. dependencies Pull requests that update a dependency file. labels Sep 13, 2024

jasnell force-pushed the move-evp-stuff-to-ncrypto branch from 143b9f4 to 0197af6 Compare September 20, 2024 21:57

This comment was marked as outdated.

Sign in to view

src: move evp stuff to ncrypto

3f5d3ca

jasnell force-pushed the move-evp-stuff-to-ncrypto branch from 0197af6 to 3f5d3ca Compare September 21, 2024 15:33

This comment was marked as outdated.

Sign in to view

anonrig approved these changes Sep 21, 2024

View reviewed changes

This comment was marked as outdated.

Sign in to view

jasnell added a commit that referenced this pull request Sep 23, 2024

src: move evp stuff to ncrypto

c4681d5

PR-URL: #54911 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

jasnell closed this Sep 23, 2024

aduh95 added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 25, 2024

targos pushed a commit that referenced this pull request Oct 4, 2024

src: move evp stuff to ncrypto

3a1485a

PR-URL: #54911 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 mentioned this pull request Oct 9, 2024

V22.10.0 proposal #55343

Merged

louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024

src: move evp stuff to ncrypto

4802db0

PR-URL: nodejs#54911 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

codebytere added a commit to electron/electron that referenced this pull request Nov 20, 2024

src: move evp stuff to ncrypto

52d647b

nodejs/node#54911

codebytere added a commit to electron/electron that referenced this pull request Nov 20, 2024

src: move evp stuff to ncrypto

e1810c3

nodejs/node#54911

tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024

src: move evp stuff to ncrypto

f14b28e

PR-URL: nodejs#54911 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

codebytere added a commit to electron/electron that referenced this pull request Nov 21, 2024

src: move evp stuff to ncrypto

ca30d76

nodejs/node#54911

codebytere added a commit to electron/electron that referenced this pull request Dec 3, 2024

src: move evp stuff to ncrypto

48ec868

nodejs/node#54911

codebytere added a commit to electron/electron that referenced this pull request Dec 4, 2024

src: move evp stuff to ncrypto

1dc9f55

nodejs/node#54911

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src: move evp stuff to ncrypto #54911

src: move evp stuff to ncrypto #54911

jasnell commented Sep 12, 2024

nodejs-github-bot commented Sep 12, 2024

nodejs-github-bot commented Sep 12, 2024

codecov bot commented Sep 12, 2024 •

edited

Loading

anonrig Sep 12, 2024

anonrig Sep 13, 2024

jasnell Sep 21, 2024

panva commented Sep 14, 2024 •

edited

Loading

jasnell commented Sep 20, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Sep 22, 2024

jasnell commented Sep 23, 2024

		if (!error.IsEmpty()) env->isolate()->ThrowException(error);
		return false;

src: move evp stuff to ncrypto #54911

src: move evp stuff to ncrypto #54911

Conversation

jasnell commented Sep 12, 2024

nodejs-github-bot commented Sep 12, 2024

nodejs-github-bot commented Sep 12, 2024

codecov bot commented Sep 12, 2024 • edited Loading

Codecov Report

anonrig Sep 12, 2024

Choose a reason for hiding this comment

anonrig Sep 13, 2024

Choose a reason for hiding this comment

jasnell Sep 21, 2024

Choose a reason for hiding this comment

panva commented Sep 14, 2024 • edited Loading

jasnell commented Sep 20, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Sep 22, 2024

jasnell commented Sep 23, 2024

codecov bot commented Sep 12, 2024 •

edited

Loading

panva commented Sep 14, 2024 •

edited

Loading