src: cleanup per env handles directly without a list #54993
Merged
+19
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
The format-cpp is producing incomplete output files. Might be related to recent update #53957. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54993 +/- ##
=======================================
Coverage 88.03% 88.03%
=======================================
Files 652 652
Lines 183759 183753 -6
Branches 35861 35855 -6
=======================================
+ Hits 161770 161775 +5
+ Misses 15239 15235 -4
+ Partials 6750 6743 -7
|
anonrig
approved these changes
Sep 18, 2024
Environment handles can be cleaned up directly without saving the references in a list and iterate the list.
legendecas
force-pushed
the
env/handle-cleanup
branch
from
5af8931
to
5c8d0df
Compare
github-actions
bot
removed
the
request-ci
joyeecheung
approved these changes
Sep 19, 2024
legendecas
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 8b8fc53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment handles are deterministic and can be cleaned up directly
without saving the references in a list and iterate the list.