Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix eslint makefile target #54999

Merged
merged 1 commit into from
Sep 20, 2024
Merged

build: fix eslint makefile target #54999

merged 1 commit into from
Sep 20, 2024

Conversation

RedYetiDev
Copy link
Member

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Sep 18, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.73%. Comparing base (6dfa3e4) to head (8b1724c).
Report is 38 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54999      +/-   ##
==========================================
- Coverage   88.03%   87.73%   -0.30%     
==========================================
  Files         652      652              
  Lines      183765   183765              
  Branches    35858    35520     -338     
==========================================
- Hits       161771   161229     -542     
- Misses      15239    15770     +531     
- Partials     6755     6766      +11

see 67 files with indirect coverage changes

@jazelly
Copy link
Member

jazelly commented Sep 19, 2024

I applied the change and it works fine now (at least no more reproducible). Thanks

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62554/

marco-ippolito
marco-ippolito approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@marco-ippolito marco-ippolito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (thanks for fixing it)

@marco-ippolito marco-ippolito added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 19, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62555/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62593/

@RedYetiDev
Copy link
Member Author

CI LGTM

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2024
@nodejs-github-bot nodejs-github-bot merged commit 81cc729 into nodejs:main Sep 20, 2024
67 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 81cc729

targos pushed a commit that referenced this pull request Oct 4, 2024
@RedYetiDev @targos
build: fix eslint makefile target
a81f368 
PR-URL: #54999
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@RedYetiDev @louwers
build: fix eslint makefile target
5e37a59 
PR-URL: nodejs#54999
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RedYetiDev @jazelly @nodejs-github-bot @targos @marco-ippolito