test: fix test-vm-context-dont-contextify when path contains a space
#55026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the double encoding, the test would fail as soon as the path contains a space or any other char that's already encoded by `pathToFileURL`.
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Sep 20, 2024
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
richardlau
approved these changes
Sep 20, 2024
legendecas
approved these changes
Sep 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55026 +/- ##
==========================================
- Coverage 88.04% 88.03% -0.01%
==========================================
Files 652 652
Lines 183764 183764
Branches 35862 35863 +1
==========================================
- Hits 161787 161778 -9
- Misses 15233 15234 +1
- Partials 6744 6752 +8 |
aduh95
added
the
commit-queue
jasnell
approved these changes
Sep 21, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7ecc48d |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
Because of the double encoding, the test would fail as soon as the path contains a space or any other char that's already encoded by `pathToFileURL`. PR-URL: #55026 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
Because of the double encoding, the test would fail as soon as the path contains a space or any other char that's already encoded by `pathToFileURL`. PR-URL: nodejs#55026 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the double encoding, the test would fail as soon as the path contains a space or any other char that's already encoded by
pathToFileURL.