test: do not assume process.execPath contains no spaces
#55028
+151
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a bunch of tests that would fail if run from an executable that contains any char that should be escaped when run from a shell.
|
Review requested:
|
nodejs-github-bot
added
needs-ci
legendecas
reviewed
Sep 20, 2024
RedYetiDev
reviewed
Sep 20, 2024
| // The execPath might contain chars that should be escaped in a shell context. | ||
| // On non-Windows, we can pass the path via the env; `"` is not a valid char on | ||
| // Windows, so we can simply pass the path. | ||
| const execNode = (args, callback) => exec( |
There was a problem hiding this comment.
Should this be moved to common?
There was a problem hiding this comment.
I don't think so, (almost) each test has a different implementation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55028 +/- ##
==========================================
- Coverage 88.04% 88.03% -0.01%
==========================================
Files 652 652
Lines 183764 183797 +33
Branches 35862 35868 +6
==========================================
+ Hits 161787 161810 +23
- Misses 15233 15237 +4
- Partials 6744 6750 +6 |
github-actions
bot
removed
the
request-ci
legendecas
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bunch of tests that would fail if run from an executable that contains any char that should be escaped when run from a shell.