-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: check subdir correctly in cpSync #55033
Conversation
This probably will have merge conflicts with #54653. I'd like the other one to land first as this one is easier to rebase, re-review and re-approve, if that sounds good : ) |
Per the comment above, I've added |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55033 +/- ##
=======================================
Coverage 88.23% 88.23%
=======================================
Files 652 652
Lines 183912 183916 +4
Branches 35865 35862 -3
=======================================
+ Hits 162272 162283 +11
+ Misses 14915 14910 -5
+ Partials 6725 6723 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other PR has landed and indeed there are merge conflicts now.
Conflicts resolved ^ PTAL |
Commit Queue failed- Loading data for nodejs/node/pull/55033 ✔ Done loading data for nodejs/node/pull/55033 ----------------------------------- PR info ------------------------------------ Title fs: check subdir correctly in cpSync (#55033) Author Jason Zhang <xzha4350@gmail.com> (@jazelly) Branch jazelly:fix-54285 -> nodejs:main Labels c++, fs, author ready, needs-ci Commits 1 - fs: check subdir correctly in cpSync Committers 1 - Jason Zhang <xzha4350@gmail.com> PR-URL: https://github.com/nodejs/node/pull/55033 Fixes: https://github.com/nodejs/node/issues/54285 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55033 Fixes: https://github.com/nodejs/node/issues/54285 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 20 Sep 2024 21:03:08 GMT ✔ Approvals: 1 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/55033#pullrequestreview-2321643883 ✘ This PR needs to wait 71 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-09-23T09:40:40Z: https://ci.nodejs.org/job/node-test-pull-request/62685/ - Querying data for job/node-test-pull-request/62685/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11021901134 |
Landed in 7fe5bcd |
PR-URL: nodejs#55033 Fixes: nodejs#54285 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: nodejs#55033 Fixes: nodejs#54285 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Fixes: #54285