Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: unlock versions of irrelevant DB deps #55042

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

targos
Copy link
Member

@targos targos commented Sep 21, 2024

This essentially reverts e0e0b1a.

We don't bundle ESLint anymore, so the change is no longer needed.

This essentially reverts e0e0b1a.

We don't bundle ESLint anymore, so the change is no longer needed.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 21, 2024
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
@avivkeller avivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 22, 2024
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2024
@nodejs-github-bot nodejs-github-bot merged commit 0257102 into nodejs:main Sep 24, 2024
31 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0257102

targos added a commit that referenced this pull request Oct 4, 2024
This essentially reverts e0e0b1a.

We don't bundle ESLint anymore, so the change is no longer needed.

PR-URL: #55042
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
This essentially reverts e0e0b1a.

We don't bundle ESLint anymore, so the change is no longer needed.

PR-URL: nodejs#55042
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
This essentially reverts e0e0b1a.

We don't bundle ESLint anymore, so the change is no longer needed.

PR-URL: nodejs#55042
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants