Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix typos #55064

Merged
merged 1 commit into from
Sep 27, 2024
Merged

src: fix typos #55064

merged 1 commit into from
Sep 27, 2024

Conversation

NathanBaulch
Copy link
Contributor

Just thought I'd contribute some typo fixes that I stumbled on. Nothing controversial (hopefully).

Use the following command to get a quick summary of the specific corrections made:

git diff HEAD^! --word-diff-regex='\w+' -U0 \
  | grep -E '\[\-.*\-\]\{\+.*\+\}' \
  | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \
  | sort | uniq -c | sort -n

FWIW, the typos are:

  • convertables
  • colum
  • registerd
  • endpont
  • iteratable
  • verion
  • exract
  • igoring
  • indentifier
  • inhert
  • malcious
  • maximimum
  • overlayed
  • postion
  • preivous
  • satisify
  • versons
  • wich

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/startup
  • @nodejs/vm

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 22, 2024
panva
panva reviewed Sep 22, 2024
View reviewed changes
src/quic/endpoint.cc
@@ -624,7 +624,7 @@ void Endpoint::InitPerContext(Realm* realm, Local<Object> target) {
#undef V

#define V(name, _) IDX_STATS_ENDPOINT_##name,
enum IDX_STATS_ENDPONT { ENDPOINT_STATS(V) IDX_STATS_ENDPOINT_COUNT };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell is this ok? I can't find a reference to this anywhere else.

panva
panva reviewed Sep 22, 2024
View reviewed changes
Copy link
Member

@panva panva left a comment •
edited by aduh95
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Sep 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.23%. Comparing base (cfe58cf) to head (4034ead).
Report is 422 commits behind head on main.

Files with missing lines Patch % Lines
src/tracing/trace_event.h 50.00% 2 Missing ⚠️
src/quic/endpoint.cc 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #55064   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files         652      652           
  Lines      183912   183911    -1     
  Branches    35865    35870    +5     
=======================================
+ Hits       162272   162281    +9     
+ Misses      14915    14911    -4     
+ Partials     6725     6719    -6
Files with missing lines Coverage Δ
src/aliased_buffer.h 100.00% <ø> (ø)
src/compile_cache.cc 77.14% <ø> (ø)
src/cppgc_helpers.h 84.21% <ø> (ø)
src/env.cc 85.47% <ø> (ø)
src/histogram.cc 73.52% <100.00%> (ø)
src/module_wrap.cc 75.97% <ø> (-0.56%) ⬇️
src/node.cc 73.75% <ø> (ø)
src/node_messaging.cc 84.19% <ø> (+0.18%) ⬆️
src/node_task_runner.cc 89.38% <ø> (ø)
src/quic/endpoint.h 72.41% <ø> (ø)
... and 6 more

... and 35 files with indirect coverage changes

mcollina
mcollina approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62682/

@avivkeller avivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 25, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62761/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 27, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 27, 2024
@nodejs-github-bot nodejs-github-bot merged commit b5fb2ff into nodejs:main Sep 27, 2024
68 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b5fb2ff

@NathanBaulch NathanBaulch deleted the typos-src branch September 29, 2024 06:58
targos pushed a commit that referenced this pull request Oct 4, 2024
@NathanBaulch @targos
src: fix typos
ff5d72a 
PR-URL: #55064
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Oct 4, 2024
@NathanBaulch @targos
src: fix typos
706e961 
PR-URL: #55064
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@NathanBaulch @louwers
src: fix typos
0be786b 
PR-URL: nodejs#55064
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@NathanBaulch @tpoisseau
src: fix typos
8d2de1f 
PR-URL: nodejs#55064
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva left review comments

@lpinca lpinca lpinca approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@NathanBaulch @nodejs-github-bot @mcollina @panva @lpinca @marco-ippolito @avivkeller