Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix typos #55065

Merged
merged 1 commit into from
Sep 25, 2024
Merged

lib: fix typos #55065

merged 1 commit into from
Sep 25, 2024

Conversation

NathanBaulch
Copy link
Contributor

Just thought I'd contribute some typo fixes that I stumbled on. Nothing controversial (hopefully).

Use the following command to get a quick summary of the specific corrections made:

git diff HEAD^! --word-diff-regex='\w+' -U0 \
  | grep -E '\[\-.*\-\]\{\+.*\+\}' \
  | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \
  | sort | uniq -c | sort -n

FWIW, the typos are:

  • relm
  • interal
  • proccess
  • chek
  • implemention
  • mached
  • redudant
  • undeterministic
  • connot
  • gloabl
  • overriden
  • polute
  • stirng
  • transferrable

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/loaders
  • @nodejs/net
  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 22, 2024
panva
panva reviewed Sep 22, 2024
View reviewed changes
Copy link
Member

@panva panva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

avivkeller
avivkeller reviewed Sep 22, 2024
View reviewed changes
lib/internal/errors.js
@@ -1715,7 +1715,7 @@ E('ERR_STREAM_DESTROYED', 'Cannot call %s after a stream was destroyed', Error);
E('ERR_STREAM_NULL_VALUES', 'May not write null values to stream', TypeError);
E('ERR_STREAM_PREMATURE_CLOSE', 'Premature close', Error);
E('ERR_STREAM_PUSH_AFTER_EOF', 'stream.push() after EOF', Error);
E('ERR_STREAM_UNABLE_TO_PIPE', 'Connot pipe to a closed or destroyed stream', Error);
E('ERR_STREAM_UNABLE_TO_PIPE', 'Cannot pipe to a closed or destroyed stream', Error);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this semver-major, as it changes an error code's output?

Copy link
Member

@panva panva Sep 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the message of an error that has a code is not semver-major PRs that contain breaking changes and should be released in the next major version. , see collaborator-guide

@codecov Codecov
Copy link

codecov bot commented Sep 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (cfe58cf) to head (4dc8db1).
Report is 422 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55065      +/-   ##
==========================================
+ Coverage   88.23%   88.24%   +0.01%     
==========================================
  Files         652      652              
  Lines      183912   183911       -1     
  Branches    35865    35865              
==========================================
+ Hits       162272   162293      +21     
+ Misses      14915    14902      -13     
+ Partials     6725     6716       -9
Files with missing lines Coverage Δ
lib/internal/crypto/keys.js 95.75% <100.00%> (ø)
lib/internal/crypto/webidl.js 98.29% <100.00%> (ø)
lib/internal/dns/utils.js 99.43% <100.00%> (ø)
lib/internal/errors.js 96.98% <100.00%> (ø)
lib/internal/fs/glob.js 91.76% <100.00%> (ø)
lib/internal/modules/esm/fetch_module.js 43.37% <100.00%> (ø)
lib/internal/modules/esm/loader.js 98.34% <100.00%> (ø)
lib/internal/process/finalization.js 96.00% <100.00%> (ø)
lib/internal/source_map/source_map_cache_map.js 85.21% <100.00%> (ø)
lib/internal/test_runner/mock/mock_timers.js 98.70% <100.00%> (ø)
... and 4 more

... and 25 files with indirect coverage changes

mcollina
mcollina approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62681/

mertcanaltin
mertcanaltin approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@mertcanaltin mertcanaltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@avivkeller avivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 23, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62757/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 25, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 25, 2024
@nodejs-github-bot nodejs-github-bot merged commit 4c04535 into nodejs:main Sep 25, 2024
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4c04535

@NathanBaulch NathanBaulch deleted the typos-lib branch September 25, 2024 20:24
targos pushed a commit that referenced this pull request Oct 4, 2024
@NathanBaulch @targos
lib: fix typos
bf7d7ae 
PR-URL: #55065
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@NathanBaulch @louwers
lib: fix typos
ce508a2 
PR-URL: nodejs#55065
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@NathanBaulch @tpoisseau
lib: fix typos
b07d17d 
PR-URL: nodejs#55065
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avivkeller avivkeller avivkeller left review comments

@panva panva panva left review comments

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

@mertcanaltin mertcanaltin mertcanaltin approved these changes

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.