-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: fix module print timing when specifier includes "
#55150
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55150 +/- ##
==========================================
- Coverage 88.23% 88.18% -0.05%
==========================================
Files 651 649 -2
Lines 183902 183327 -575
Branches 35855 35686 -169
==========================================
- Hits 162269 161672 -597
- Misses 14926 15024 +98
+ Partials 6707 6631 -76
|
From what I remember, almost all places that use/expose trace labels are susceptible to this issue, I don't remember exactly the places but I think could be something worthy to take a double look. Fixing this implementation also fixes the |
Do you have an example? Naive testing ( |
@aduh95 The generated logs are in json, and the json file is broken. Edit2: I'm okay with adding tests in another PR (since the CI of this PR is already green) |
Landed in 78f421d |
PR-URL: #55150 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
PR-URL: nodejs#55150 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
PR-URL: nodejs#55150 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Currently, we generate invalid JSON if the specifier contains
"
, this can be addressed by escaping all double quotes like this PR is doing.