Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: enforce errors to not be documented in legacy section #55218

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

avivkeller
Copy link
Member

@avivkeller avivkeller commented Oct 1, 2024

This PR updates the lint rule to enforce that errors are in the right category. That is, errors that exist are not placed under the deprecated cateogory.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Oct 1, 2024
@avivkeller avivkeller added the tools Issues and PRs related to the tools directory. label Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (1d5ed72) to head (dc1320c).
Report is 305 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55218      +/-   ##
==========================================
- Coverage   88.41%   88.40%   -0.02%     
==========================================
  Files         652      652              
  Lines      186572   186572              
  Branches    36045    36041       -4     
==========================================
- Hits       164957   164938      -19     
- Misses      14899    14905       +6     
- Partials     6716     6729      +13     

see 31 files with indirect coverage changes

doc/api/errors.md Outdated Show resolved Hide resolved
@aduh95 aduh95 changed the title doc: put errors in right location tools: enforce errors to not be documented in legacy section Oct 2, 2024
@avivkeller avivkeller closed this Oct 2, 2024
@avivkeller
Copy link
Member Author

avivkeller commented Oct 2, 2024

ack! That's not what I meant to do. --force will be the end of me...

I'll reopen in a moment.

@avivkeller avivkeller reopened this Oct 2, 2024
@avivkeller avivkeller requested a review from aduh95 October 2, 2024 16:24
doc/api/errors.md Outdated Show resolved Hide resolved
@aduh95
Copy link
Contributor

aduh95 commented Oct 2, 2024

Can you please rebase?

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@avivkeller avivkeller added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Oct 2, 2024
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 2, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62900/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 8, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/55218
✔  Done loading data for nodejs/node/pull/55218
----------------------------------- PR info ------------------------------------
Title      tools: enforce errors to not be documented in legacy section (#55218)
Author     Aviv Keller <redyetidev@gmail.com> (@RedYetiDev)
Branch     RedYetiDev:patch-531581 -> nodejs:main
Labels     doc, tools, errors, author ready, commit-queue-squash
Commits    3
 - tools: enforce errors to not be documented in legacy section
 - fixup! tools: enforce errors to not be documented in legacy section
 - Update documented-errors.js
Committers 2
 - RedYetiDev <38299977+RedYetiDev@users.noreply.github.com>
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/55218
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55218
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 01 Oct 2024 16:58:13 GMT
   ✔  Approvals: 1
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/55218#pullrequestreview-2343976038
   ✘  This PR needs to wait 7 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-10-02T20:14:07Z: https://ci.nodejs.org/job/node-test-pull-request/62900/
- Querying data for job/node-test-pull-request/62900/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/11233008727

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 8, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2024
@nodejs-github-bot nodejs-github-bot merged commit 5a3da7b into nodejs:main Oct 8, 2024
75 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5a3da7b

aduh95 pushed a commit that referenced this pull request Oct 9, 2024
PR-URL: #55218
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
PR-URL: nodejs#55218
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@marco-ippolito marco-ippolito added the backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. label Nov 16, 2024
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
PR-URL: nodejs#55218
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants