build,src: add Intel Vtune profiling support #5527

cdai2 · 2016-03-02T17:56:11Z

Pull Request check-list

Please make sure to review and check all of these items:

Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
this change (including linting)?
Is the commit message formatted according to CONTRIBUTING.md?
If this change fixes a bug (or a performance problem), is a regression
test (or a benchmark) included?
Is a documentation update included (if this change modifies
existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)

Description of change

Please provide a description of the change here.

This feature supports the Intel Vtune profiling support for JITted
JavaScript on IA32 / X64 / X32 platform. The advantage of this profiling
is that the user / developer of NodeJS application can get the detailed
profiling information for every line of the JavaScript source code.
This information will be very useful for the owner to optimize their
applications.

This feature is a compile-time option. For windows platform, the user
needs to pass the following parameter to vcbuild.bat: "enable-vtune"

For other OS, the user needs to pass the following parameter to
./configure command: "--enable-vtune-profiling"

PR-URL: #3785
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl

jasnell · 2016-03-02T18:11:50Z

LGTM

bnoordhuis · 2016-03-02T18:44:34Z

LGTM2. CI: https://ci.nodejs.org/job/node-test-pull-request/1812/

bnoordhuis · 2016-03-02T18:44:57Z

Also, /cc @nodejs/lts.

jbergstroem · 2016-03-03T08:33:41Z

fwiw LGTM

MylesBorins · 2016-03-17T17:25:54Z

@cdai2 I'm sorry this ended up going under the radar. We'll be sure to get it in the next minor release of v4.x

Can you rebase against v4.x-staging?

jasnell · 2016-03-21T23:54:24Z

@cdai2 ... ping

cdai2 · 2016-03-22T07:52:42Z

@thealphanerd & @jasnell:
Thanks for notification. I will do it today.

cdai2 · 2016-03-22T08:28:44Z

@thealphanerd:

Hi, pull request updated.
thanks.

PR-URL: nodejs#5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

IPv6 addresses in Host header (URI), must be enclosed within square brackets, in order to properly separate the host address from any port reference. PR-URL: nodejs#5314 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

Original commit message: Make NumberFormat use the ICU currency data, fix bug in NumberFormat NumberFormat previously just used a min of 0 digits after the decimal and a max of 3. This CL changes it so that we use the ICU currency data, and set the min and max to the number of numbers after the decimal point for each currency. This CL also fixes a small bug where if the minimum fraction digits is above 3 but the maximum fraction digits isn't set, then it returns with only three numbers after the decimal point. BUG=435465,473104,304722 LOG=Y Review URL: https://codereview.chromium.org/1231613006 Cr-Commit-Position: refs/heads/master@{nodejs#29734} PR-URL: nodejs#6275 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

Original commit message: Fix user options for fractional digits in Intl.NumberFormatter The patch in https://crrev.com/ddb5c2d999c5ee6e31c4a9599bb3ddb293cc3f49 moved all fractional digit settings to default values due to a coding error. These were not even correct default values, and users observed errors where percentages were written as "23.0%" instead of "23%". This patch fixes the setting propagation when appropriate and it changes the default max fractional digits of a percentage to 0, per spec. BUG=chromium:544122 R=mnita,jochen CC=hichris123,adamk LOG=Y Review URL: https://codereview.chromium.org/1420883002 Cr-Commit-Position: refs/heads/master@{nodejs#31468} PR-URL: nodejs#6275 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

This commit refines the documentation around child.kill(), where kill attempts against shells will lead to unexpected results. Namely, on linux the child process of a child process will not terminate, when its parent gets terminated. This is different across the the platforms. PR-URL: nodejs#2098 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Closes: nodejs#2098

PR-URL: nodejs#6194 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

PR-URL: nodejs#6225 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

* Modify tools/license-builder.sh to support ICU 57.1's plain text license. (Separate issue to add ICU 57.1 in nodejs#6058) * Update/regenerate LICENSE to include ICU 57.1's license * Note that because the tool was rerun, the change in nodejs#6065 is already included here. PR-URL: nodejs#6068 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#6257 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell · 2016-04-21T18:00:12Z

@thealphanerd @cdai2 ... looks like this needs another rebase.

MylesBorins · 2016-04-21T18:13:21Z

@jasnell we should probably start discussing another minor for LTS in the near future to avoid this from perpetually being in limbo :S

This feature supports the Intel Vtune profiling support for JITted JavaScript on IA32 / X64 / X32 platform. The advantage of this profiling is that the user / developer of NodeJS application can get the detailed profiling information for every line of the JavaScript source code. This information will be very useful for the owner to optimize their applications. This feature is a compile-time option. For windows platform, the user needs to pass the following parameter to vcbuild.bat: "enable-vtune" For other OS, the user needs to pass the following parameter to ./configure command: "--enable-vtune-profiling" PR-URL: nodejs#3785 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

cdai2 · 2016-04-22T06:28:21Z

hi,
Pull request updated.
thanks.

jasnell · 2016-04-22T14:18:14Z

@thealphanerd ... agreed. perhaps one more patch round followed by a minor? We can put this on the @nodejs/lts agenda for monday.

This feature supports the Intel Vtune profiling support for JITted JavaScript on IA32 / X64 / X32 platform. The advantage of this profiling is that the user / developer of NodeJS application can get the detailed profiling information for every line of the JavaScript source code. This information will be very useful for the owner to optimize their applications. This feature is a compile-time option. For windows platform, the user needs to pass the following parameter to vcbuild.bat: "enable-vtune" For other OS, the user needs to pass the following parameter to ./configure command: "--enable-vtune-profiling" Ref: #3785 PR-URL: #5527 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

MylesBorins · 2016-06-01T20:23:33Z

landed in 4ca90de

This feature supports the Intel Vtune profiling support for JITted JavaScript on IA32 / X64 / X32 platform. The advantage of this profiling is that the user / developer of NodeJS application can get the detailed profiling information for every line of the JavaScript source code. This information will be very useful for the owner to optimize their applications. This feature is a compile-time option. For windows platform, the user needs to pass the following parameter to vcbuild.bat: "enable-vtune" For other OS, the user needs to pass the following parameter to ./configure command: "--enable-vtune-profiling" Ref: #3785 PR-URL: #5527 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

Notable Changes: This list is not yet complete. Please comment in the thread with commits you think should be included. Descriptions will also be updated in a later release candidate. Semver Minor: * buffer: * backport new buffer constructor APIs to v4.x (Сковорода Никита Андреевич) #7562 * ignore negative allocation lengths (Anna Henningsen) #7562 * backport --zero-fill-buffers cli option (James M Snell) #5745 * build: * add Intel Vtune profiling support (Chunyang Dai) #5527 * repl: * copying tabs shouldn't trigger completion (Eugene Obrezkov) #5958 * src: * add node::FreeEnvironment public API (Cheng Zhao) #3098 * test: * run v8 tests from node tree (Bryon Leung) #4704 * V8: * backport 9c927d0f01 from V8 upstream (Myles Borins) #7451 * cherry-pick 68e89fb from v8's upstream (Fedor Indutny) #3779 Semver Patch: * **libuv**: * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) #6796 * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé) #5994

Notable Changes: This list is not yet complete. Please comment in the thread with commits you think should be included. Descriptions will also be updated in a later release candidate. Semver Minor: * buffer: * backport new buffer constructor APIs to v4.x (Сковорода Никита Андреевич) #7562 * ignore negative allocation lengths (Anna Henningsen) #7562 * backport --zero-fill-buffers cli option (James M Snell) #5745 * build: * add Intel Vtune profiling support (Chunyang Dai) #5527 * repl: * copying tabs shouldn't trigger completion (Eugene Obrezkov) #5958 * src: * add node::FreeEnvironment public API (Cheng Zhao) #3098 * test: * run v8 tests from node tree (Bryon Leung) #4704 * V8: * Add post portem data to imrpove object inspection and function's context variables inspection (Fedor Indutny) #3779 Semver Patch: * **libuv**: * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) #6796 * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé) #5994

Notable Changes: This list is not yet complete. Please comment in the thread with commits you think should be included. Descriptions will also be updated in a later release candidate. Semver Minor: * buffer: * backport new buffer constructor APIs to v4.x (Сковорода Никита Андреевич) #7562 * backport --zero-fill-buffers cli option (James M Snell) #5745 * build: * add Intel Vtune profiling support (Chunyang Dai) #5527 * repl: * copying tabs shouldn't trigger completion (Eugene Obrezkov) #5958 * src: * add node::FreeEnvironment public API (Cheng Zhao) #3098 * test: * run v8 tests from node tree (Bryon Leung) #4704 * V8: * Add post portem data to imrpove object inspection and function's context variables inspection (Fedor Indutny) #3779 Semver Patch: * **buffer**: * ignore negative allocation lengths (Anna Henningsen) #7562 * **libuv**: * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) #6796 * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé) #5994 * **npm**: * upgrade to 2.15.9 (Kat Marchán) #7692

Notable Changes: Semver Minor: * buffer: * backport new buffer constructor APIs to v4.x (Сковорода Никита Андреевич) #7562 * backport --zero-fill-buffers cli option (James M Snell) #5745 * build: * add Intel Vtune profiling support (Chunyang Dai) #5527 * repl: * copying tabs shouldn't trigger completion (Eugene Obrezkov) #5958 * src: * add node::FreeEnvironment public API (Cheng Zhao) #3098 * test: * run v8 tests from node tree (Bryon Leung) #4704 * V8: * Add post mortem data to improve object inspection and function's context variables inspection (Fedor Indutny) #3779 Semver Patch: * **buffer**: * ignore negative allocation lengths (Anna Henningsen) #7562 * **crypto**: * update root certificates (Ben Noordhuis) #7363 * **libuv**: * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) #6796 * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé) #5994 * **npm**: * upgrade to 2.15.9 (Kat Marchán) #7692

jasnell added build Issues and PRs related to build files or the CI. lts-watch-v4.x labels Mar 2, 2016

jasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Mar 2, 2016

bnoordhuis mentioned this pull request Mar 2, 2016

build,src: add Intel Vtune profiling support #4135

Closed

MylesBorins force-pushed the v4.x-staging branch from a300696 to cbb9633 Compare March 17, 2016 17:22

cdai2 force-pushed the v4.x-staging branch from 32a3a6f to 748e761 Compare March 22, 2016 08:06

MylesBorins force-pushed the v4.x-staging branch from 825db16 to ab5ad06 Compare March 22, 2016 22:57

MylesBorins self-assigned this Mar 30, 2016

MylesBorins force-pushed the v4.x-staging branch from df3a543 to 7384140 Compare April 1, 2016 01:32

MylesBorins added the v4.x label Apr 11, 2016

Myles Borins and others added 12 commits April 12, 2016 18:04

Working on v4.4.4

9a8aee8

src,tools: allow utf-8 in built-in js source code

78726a7

PR-URL: nodejs#5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

src,tools: drop nul byte from built-in source code

db4bc97

PR-URL: nodejs#5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

src,tools: remove null sentinel from source array

9200d18

PR-URL: nodejs#5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

deps: upgrade npm in LTS to 2.15.2

3d70b8a

tools: remove obsolete npm test-legacy command

c92febf

doc: fix incorrect references in buffer docs

36dd7cb

PR-URL: nodejs#6194 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

srl295 and others added 2 commits April 20, 2016 23:48

doc: DCO anchor that doesn't change

6291de2

PR-URL: nodejs#6257 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

cdai2 force-pushed the v4.x-staging branch from 748e761 to ee9ffaa Compare April 22, 2016 05:54

MylesBorins force-pushed the v4.x-staging branch from 6291de2 to a8312f2 Compare April 22, 2016 17:50

MylesBorins force-pushed the v4.x-staging branch from b511c5a to 8501783 Compare May 6, 2016 01:29

MylesBorins mentioned this pull request May 16, 2016

Release Schedule for v4.4.5 and v4.5.0 nodejs/Release#102

Closed

MylesBorins force-pushed the v4.x-staging branch from c6db822 to 6330f48 Compare May 24, 2016 18:47

MylesBorins closed this Jun 1, 2016

MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Jun 1, 2016

MylesBorins mentioned this pull request Jul 12, 2016

Semver-Minor commits in v4.x-staging nodejs/Release#120

Closed

MylesBorins mentioned this pull request Jul 12, 2016

v4.5.0 proposal #7688

Merged

MylesBorins removed their assignment Dec 27, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build,src: add Intel Vtune profiling support #5527

build,src: add Intel Vtune profiling support #5527

cdai2 commented Mar 2, 2016

jasnell commented Mar 2, 2016

bnoordhuis commented Mar 2, 2016

bnoordhuis commented Mar 2, 2016

jbergstroem commented Mar 3, 2016

MylesBorins commented Mar 17, 2016

jasnell commented Mar 21, 2016

cdai2 commented Mar 22, 2016

cdai2 commented Mar 22, 2016

jasnell commented Apr 21, 2016

MylesBorins commented Apr 21, 2016

cdai2 commented Apr 22, 2016

jasnell commented Apr 22, 2016

MylesBorins commented Jun 1, 2016

build,src: add Intel Vtune profiling support #5527

build,src: add Intel Vtune profiling support #5527

Conversation

cdai2 commented Mar 2, 2016

Pull Request check-list

Affected core subsystem(s)

Description of change

jasnell commented Mar 2, 2016

bnoordhuis commented Mar 2, 2016

bnoordhuis commented Mar 2, 2016

jbergstroem commented Mar 3, 2016

MylesBorins commented Mar 17, 2016

jasnell commented Mar 21, 2016

cdai2 commented Mar 22, 2016

cdai2 commented Mar 22, 2016

jasnell commented Apr 21, 2016

MylesBorins commented Apr 21, 2016

cdai2 commented Apr 22, 2016

jasnell commented Apr 22, 2016

MylesBorins commented Jun 1, 2016