-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: update test_util.cc for coverage #55291
Conversation
update test_util.cc for code coverage src/util-inl.h:PopFront()
Why is this change important? IIRC the coverage of individual CPP functions isn't important, right? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55291 +/- ##
=======================================
Coverage 88.41% 88.42%
=======================================
Files 652 652
Lines 186612 186612
Branches 36062 36058 -4
=======================================
+ Hits 165001 165006 +5
+ Misses 14885 14880 -5
Partials 6726 6726 |
Thank you for the comment! As you mentioned, I also think the coverage of individual cpp function is not important. |
Landed in b579779 |
update test_util.cc for code coverage src/util-inl.h:PopFront() PR-URL: nodejs#55291 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
test: update test_util.cc for code coverage
target file
target function
AS-IS
TO-BE