Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc, installer: win - new logo in installer; optim .jpg #5531

Closed
wants to merge 1 commit into from
Closed

doc, installer: win - new logo in installer; optim .jpg #5531

wants to merge 1 commit into from

Conversation

eljefedelrodeodeljefe
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

tools

Description of change

Latest logo iteration makes image adaptation necessary, #5381.
I couldn't get wix or VS to run properly (new to windows dev), but according to what I see in the installer and read in the wix project, this should suffice.

had to close #5391 and reopen here due to rebase foo and GH not being able to reopen closed force-pushed branches. Sorry.

/cc @rvagg can you give Jenkins a try? Could build locally.

@mscdex mscdex added windows Issues and PRs related to the Windows platform. install Issues and PRs related to the installers. labels Mar 2, 2016
@rvagg
Copy link
Member

rvagg commented Mar 3, 2016

https://nodejs.org/download/test/v6.0.0-test20160303761abde90c/

I don't have a Windows machine or VM handy right now to test so could you screenshot both the x86 and x64 installers and post them here please @eljefedelrodeodeljefe?

@eljefedelrodeodeljefe
Copy link
Contributor Author

On parallels, Win10:

x64
node_js_setup
node_js_setup

x86
node_js_setup
node_js_setup

@rvagg
Copy link
Member

rvagg commented Mar 3, 2016

Nice, my only question now is whether we should change the Node green bar at the top to match the new style. @nodejs/website can you please look at the above screenshots and tell us if they are acceptable or should we move the strip of green at the top to a different colour, and if so, what colour?

@joaocgreis
Copy link
Member

Tested both installers on Windows 2008 R2, both look fine, as the screenshots above for Windows 10.

doc, installer: change stripe color to RGB 68 136 62
@eljefedelrodeodeljefe
Copy link
Contributor Author

Changed the color to the middle tone. See RGB in commit. Squashed the thing.

@rvagg When you decide to land this, I'd actually propose on a separate issue to redesign the installer to something more win10 "tile"-like design. Something that might be nice on my quest for a better win dev UX. Maybe then someone wants to throw in some design ideas.

@Fishrock123
Copy link
Contributor

Could you make sure to run the image though imageoptim / optipng (also for jpeg) or similar tools? (Make sure you don't loose quality though)

@eljefedelrodeodeljefe
Copy link
Contributor Author

ran it through imageoptim. Do you see anything specific?

@Fishrock123
Copy link
Contributor

No I just wanted to make sure, less binary bytes in git.

@eljefedelrodeodeljefe
Copy link
Contributor Author

Ah, alright. FYI It's 7 and 9kb now, with 9-14% optimization. When I did it with .png it was even over 30%.

@ChALkeR
Copy link
Member

ChALkeR commented Mar 5, 2016

@Fishrock123 Btw, just running optipng does not give the best result. Even running plain simple advdef afterwards saves a few more bytes. Note that advdef is not even a png optimizer, it does not touch the internal png structure. It just recompresses things.

@silverwind
Copy link
Contributor

LGTM

@rvagg
Copy link
Member

rvagg commented Mar 7, 2016

lgtm

landed @ 44c9751 thanks @eljefedelrodeodeljefe

@rvagg rvagg closed this Mar 7, 2016
rvagg pushed a commit that referenced this pull request Mar 7, 2016
also change stripe color to RGB 68 136 62

PR-URL: #5531
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>
@Fishrock123 Fishrock123 mentioned this pull request Mar 7, 2016
Fishrock123 pushed a commit that referenced this pull request Mar 8, 2016
also change stripe color to RGB 68 136 62

PR-URL: #5531
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>
Fishrock123 pushed a commit that referenced this pull request Mar 8, 2016
also change stripe color to RGB 68 136 62

PR-URL: #5531
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
also change stripe color to RGB 68 136 62

PR-URL: #5531
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
also change stripe color to RGB 68 136 62

PR-URL: #5531
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
also change stripe color to RGB 68 136 62

PR-URL: #5531
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>
@MylesBorins MylesBorins mentioned this pull request Mar 21, 2016
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.

Notable Changes:

* build:
  - Updated Logos for the OSX + Windows installers
    - (Rod Vagg) #5401
    - (Robert Jefe Lindstaedt) #5531
  - New option to select you VS Version in the Windows installer
    - (julien.waechter) #4645
  - Support Visual C++ Build Tools 2015
    - (João Reis) #5627
* tools:
  - Gyp now works on OSX without XCode
    - (Shigeki Ohtsu) #1325
MylesBorins pushed a commit that referenced this pull request Mar 22, 2016
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.

Notable Changes:

* build:
  - Updated Logos for the OSX + Windows installers
    - (Rod Vagg) #5401
    - (Robert Jefe Lindstaedt) #5531
  - New option to select your VS Version in the Windows installer
    - (julien.waechter) #4645
  - Support Visual C++ Build Tools 2015
    - (João Reis) #5627
* tools:
  - Gyp now works on OSX without XCode
    - (Shigeki Ohtsu) #1325
MylesBorins pushed a commit that referenced this pull request Mar 22, 2016
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.

Notable Changes:

* build:
  - Updated Logos for the OSX + Windows installers
    - (Rod Vagg) #5401
    - (Robert Jefe Lindstaedt) #5531
  - New option to select your VS Version in the Windows installer
    - (julien.waechter) #4645
  - Support Visual C++ Build Tools 2015
    - (João Reis) #5627
* tools:
  - Gyp now works on OSX without XCode
    - (Shigeki Ohtsu) #1325

PR-URL: #5835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
install Issues and PRs related to the installers. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants