Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix tests when Amaro is unavailable #55320

Merged
merged 1 commit into from
Oct 11, 2024
Merged

test: fix tests when Amaro is unavailable #55320

merged 1 commit into from
Oct 11, 2024

Conversation

richardlau
Copy link
Member

Fix two tests that fail when node is configured --without-amaro.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 8, 2024
@richardlau richardlau marked this pull request as draft October 8, 2024 15:03
@avivkeller
Copy link
Member

avivkeller commented Oct 8, 2024 •
edited
Loading

This isn't right, process.features.typescript will check whether the currently running process supports typescript, not whether the executable does. The correct value to check would be process.config.variables.node_use_amaro

@avivkeller avivkeller added the strip-types Issues or PRs related to strip-types support label Oct 8, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.39%. Comparing base (9f9069d) to head (207741a).
Report is 248 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55320      +/-   ##
==========================================
- Coverage   88.39%   88.39%   -0.01%     
==========================================
  Files         652      652              
  Lines      186777   186777              
  Branches    36039    36039              
==========================================
- Hits       165109   165100       -9     
- Misses      14917    14927      +10     
+ Partials     6751     6750       -1

see 30 files with indirect coverage changes

@aduh95
Copy link
Contributor

aduh95 commented Oct 8, 2024

We might want fix the commit message as well s/when amaro unavailable/when Amaro is unavailable/.

@richardlau
Copy link
Member Author

This isn't right, process.features.typescript will check whether the currently running process supports typescript, not whether the executable does. The correct value to check would be process.config.variables.node_use_amaro

I figured this out (which is why I changed the state back to draft). Currently running tests locally (both with and without amaro) before pushing up the correction.

@richardlau

This comment was marked as off-topic.

Sign in to view
@marco-ippolito
Copy link
Member

marco-ippolito commented Oct 8, 2024 •
edited
Loading

also should actually set process.features.typescript to false if amaro is not loaded

@richardlau richardlau marked this pull request as ready for review October 8, 2024 15:58
@richardlau richardlau changed the title test: fix tests when amaro unavailable test: fix tests when Amaro is unavailable Oct 8, 2024
@aduh95 aduh95 mentioned this pull request Oct 8, 2024
Merged
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@avivkeller avivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 8, 2024
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 10, 2024
@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 10, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 10, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@aduh95 aduh95 removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 10, 2024
@aduh95
Copy link
Contributor

aduh95 commented Oct 10, 2024

Can you rebase?

@richardlau
Copy link
Member Author

Can you rebase?

👍. Will do so once the linter failure on main is fixed.

@richardlau
test: fix tests when Amaro is unavailable
207741a 
Fix two tests that fail when `node` is configured `--without-amaro`.
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2024
@richardlau
Copy link
Member Author

Can you rebase?

👍. Will do so once the linter failure on main is fixed.

Rebased.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63040/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63041/

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2024
@nodejs-github-bot nodejs-github-bot merged commit 82dab76 into nodejs:main Oct 11, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 82dab76

aduh95 pushed a commit that referenced this pull request Oct 11, 2024
@richardlau @aduh95
test: fix tests when Amaro is unavailable
3273707 
Fix two tests that fail when `node` is configured `--without-amaro`.

PR-URL: #55320
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 11, 2024
Merged
@richardlau richardlau deleted the withoutamaro branch October 11, 2024 16:22
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@richardlau @louwers
test: fix tests when Amaro is unavailable
64049bf 
Fix two tests that fail when `node` is configured `--without-amaro`.

PR-URL: nodejs#55320
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@richardlau @tpoisseau
test: fix tests when Amaro is unavailable
d872618 
Fix two tests that fail when `node` is configured `--without-amaro`.

PR-URL: nodejs#55320
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@richardlau @nodejs-github-bot @avivkeller @aduh95 @marco-ippolito @lpinca @atlowChemi