Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: enforce ordering of error codes in errors.md #55324

Merged
merged 2 commits into from
Oct 10, 2024
Merged

tools: enforce ordering of error codes in errors.md #55324

merged 2 commits into from
Oct 10, 2024
+252 −256

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 8, 2024

It seems to be the right time to do so, just when 20.x is about to reach maintenance, so it's unlikely to cause backporting nightmares.

@aduh95 aduh95 added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Oct 8, 2024
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 8, 2024
@RedYetiDev RedYetiDev added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Oct 8, 2024
@RedYetiDev
Copy link
Member

My only nitpick is that doesn't this belong in a markdown linter, not an ESlint rule for JS?

@anonrig
Copy link
Member

anonrig commented Oct 8, 2024

My only nitpick is that doesn't this belong in a markdown linter, not an ESlint rule for JS?

https://eslint.org/blog/2024/10/eslint-json-markdown-support/

@RedYetiDev
Copy link
Member

Yes, but we aren't making use of that, and this rule is for JS files. But that can always be changed later, so it's only a nitpick

@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 8, 2024
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2024
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
lpinca
lpinca approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2024
@nodejs-github-bot nodejs-github-bot merged commit 4988bb5 into nodejs:main Oct 10, 2024
30 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4988bb5

@aduh95 aduh95 deleted the errors-ordering branch October 10, 2024 17:26
@aduh95 aduh95 mentioned this pull request Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. errors Issues and PRs related to JavaScript errors originated in Node.js core. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aduh95 @RedYetiDev @anonrig @nodejs-github-bot @lpinca @targos @MoLow