esm: mark import attributes and JSON module as stable #55333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
esm
aduh95
reviewed
Oct 9, 2024
aduh95
reviewed
Oct 9, 2024
nicolo-ribaudo
force-pushed
the
json-modules-remove-warning
branch
from
3adddfc
to
4c5a857
Compare
aduh95
reviewed
Oct 9, 2024
The two proposals reached stage 4 at the October 2024 meeting.
nicolo-ribaudo
force-pushed
the
json-modules-remove-warning
branch
from
7bd1342
to
9d6689a
Compare
richardlau
added
lts-watch-v18.x
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
anonrig
approved these changes
Oct 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55333 +/- ##
==========================================
+ Coverage 88.38% 88.40% +0.01%
==========================================
Files 652 652
Lines 186740 186739 -1
Branches 36036 36029 -7
==========================================
+ Hits 165058 165078 +20
+ Misses 14934 14925 -9
+ Partials 6748 6736 -12
|
RedYetiDev
reviewed
Oct 9, 2024
Comment on lines
+19
to
27
| it('should not print an experimental warning', async () => { | ||
| const { code, signal, stderr } = await spawnPromisified(execPath, [ | ||
| fixtures.path('/es-modules/json-modules.mjs'), | ||
| ]); | ||
|
|
||
| assert.match(stderr, /ExperimentalWarning: Importing JSON modules/); | ||
| assert.strictEqual(stderr, ''); | ||
| assert.strictEqual(code, 0); | ||
| assert.strictEqual(signal, null); | ||
| }); |
There was a problem hiding this comment.
IMO this test case can just be removed, because there is no longer any code suggesting that an experimental emitting case.
RedYetiDev
added
author ready
github-actions
bot
removed
the
request-ci
aduh95
approved these changes
Oct 9, 2024
marco-ippolito
approved these changes
Oct 10, 2024
targos
approved these changes
Oct 10, 2024
|
Process question: what does it mean to get multiple approvals after a comment suggesting a change? Should I delete the test or not? |
I think its fine to keep it |
lpinca
approved these changes
Oct 10, 2024
aduh95
added
commit-queue
mcollina
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d881fcb |
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Oct 14, 2024
The two proposals reached stage 4 at the October 2024 meeting. PR-URL: nodejs#55333 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two proposals reached stage 4 yesterday, at the October 2024 meeting. The Node.js implementation already matches exactly the semantics required by the proposals. This PR can/should be backported to 22 and 20 (and 18?).