Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: migrate from deprecated SnapshotCreator constructor #55337

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: migrate from deprecated SnapshotCreator constructor #55337

wants to merge 1 commit into from

Commits on Oct 9, 2024

  1. src: migrate from deprecated SnapshotCreator constructor 

    Previously we have been using the variant of SnapshotCreator that
only passes the external references instead of
v8::Isolate::CreateParams and it's about to be deprecated.
Switch to using the new constructor that takes a fully CreateParams
instead.

This also makes sure that the snapshot building script is using
the Node.js array buffer allocator instead of a separate default
one that was previously used by the old constructor. The zero fill
toggle in the Node.js array buffer allocator would still be ignored
during snapshot building, however, until we fixes the array buffer
allocator and let V8 own the toggle backing store instead, because
otherwise the snapshot would contain the external toggle address
and become unreproducible.
    @joyeecheung
    joyeecheung committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4968db1 View commit details
    Browse the repository at this point in the history