Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix ambasador markdown list #55361

Merged
merged 1 commit into from
Oct 13, 2024
Merged

doc: fix ambasador markdown list #55361

merged 1 commit into from
Oct 13, 2024

Conversation

RafaelGSS
Copy link
Member

as titled

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 11, 2024
@RedYetiDev
Copy link
Member

RedYetiDev commented Oct 12, 2024 •
edited
Loading

Nit: "ambassador" in the commit

@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 12, 2024
mcollina
mcollina approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 13, 2024
@nodejs-github-bot nodejs-github-bot merged commit 19c1b9d into nodejs:main Oct 13, 2024
26 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 19c1b9d

marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Oct 14, 2024
@RafaelGSS @marco-ippolito
doc: fix ambasador markdown list
fdeb8c7 
PR-URL: nodejs#55361
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@RafaelGSS @nodejs-github-bot @RedYetiDev @mcollina @benjamingr @lpinca @gireeshpunathil @marco-ippolito