Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: fix inconsistency with importAssertion in resolve hook #55365

Merged
merged 2 commits into from
Oct 15, 2024
Merged

esm: fix inconsistency with importAssertion in resolve hook #55365

merged 2 commits into from
Oct 15, 2024
+11 −4

Commits on Oct 13, 2024

  1. esm: fix inconsistency of importAssertion in resolve hook 

    As the [documentation](https://nodejs.org/docs/latest/api/module.html#customization-hooks:~:text=The%20property%20context.importAssertions%20is%20replaced%20with%20context.importAttributes.%20Using%20the%20old%20name%20is%20still%20supported%20and%20will%20emit%20an%20experimental%20warning.) says, the `context.importAssertion` should be still supported and emit a warning. This is true for the load hook, but not correct for context of the resolve hook.

This PR is tring to fix the inconsistency.
    @yesmeck
    yesmeck committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    78cfeef View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. EOL EOF

    @aduh95
    aduh95 authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    5bb8741 View commit details
    Browse the repository at this point in the history