sqlite: cache column names in stmt.all() #55373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
While the statement is running, it is impossible to modify the column names and thus it is beneficial to create the host-language (JS) keys once per all rows and reuse them for all results. With this change the performance of `.all()` improves by around 25% depending on the number of columns and rows in the result.
indutny
force-pushed
the
feature/cache-sqlite-columns
branch
from
2294c13
to
b6f3f6d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55373 +/- ##
==========================================
+ Coverage 88.40% 88.41% +0.01%
==========================================
Files 652 652
Lines 186777 186784 +7
Branches 36047 36051 +4
==========================================
+ Hits 165111 165140 +29
+ Misses 14919 14897 -22
Partials 6747 6747
|
targos
approved these changes
Oct 13, 2024
benjamingr
approved these changes
Oct 13, 2024
anonrig
approved these changes
Oct 14, 2024
github-actions
bot
removed
the
request-ci
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6abd545 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the statement is running, it is impossible to modify the column names and thus it is beneficial to create the host-language (JS) keys once per all rows and reuse them for all results.
With this change the performance of
.all()improves by around 25% depending on the number of columns and rows in the result.