-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix history info for URLSearchParams #55840
base: main
Are you sure you want to change the base?
Conversation
doc/api/url.md
Outdated
@@ -771,10 +771,22 @@ console.log(myURL.href); | |||
|
|||
#### `new URLSearchParams()` | |||
|
|||
<!-- YAML | |||
added: | |||
- v7.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class was added in v7.5.0 and the constructor in v7.0.0 🤔 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops! my mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think those additions are adding much, it's already implied that if there are no history data, it inherits from the class, having redundant info only increases the risk to let a mistake pass through
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so the nuance is that require('url').URLSearchParams
only existed after 7.5.0 (021338d), but the actual class was added along the rest of the URL
API (a8ece14) and was accessible via new URL().searchParams
. I wonder if any of our user would be sensible to the nuance – hopefully there are no v7.x users left so it doesn't matter anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's true that this history info may be useless for users (it's quite impossible to see v7.x users left)
But it is required in some cases, like browser-compat-data. And it is normal way to add history info for every single feature (especially for new features, like web crypto, web stream, worker threads). Also, parent feature and children feature are not always have the same history info, like in this PR.
ac38343
to
273830f
Compare
The commit message does not match the changes |
273830f
to
771859f
Compare
Fixed! |
Refs: #17365
Refs: #9484
Refs: #7448
Refs: #10801
Refs: mdn/browser-compat-data#24998
Add version table for:
new URLSearchParams(string)
URLSearchParams.prototype.{entries,forEach,keys,values}
Test screenshots taken from mdn/browser-compat-data#24998: