test: deflake test-watch-file-shared-dependency #56344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
lpinca
commented
Dec 23, 2024
| @@ -49,6 +49,20 @@ describe('watch file with shared dependency', () => { | |||
| watcher.unfilterFilesOwnedBy([fixturePaths['test.js']]); | |||
| watcher.filterFile(fixturePaths['test.js']); | |||
| watcher.filterFile(fixturePaths['dependency.js'], fixturePaths['test.js']); | |||
| writeFileSync(fixturePaths['dependency.js'], 'module.exports = { modified: true };'); | |||
|
|
|||
| if (common.isMacOS) { | |||
There was a problem hiding this comment.
It seems to be flaky only on macOS.
targos
approved these changes
Dec 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56344 +/- ##
=======================================
Coverage 88.54% 88.54%
=======================================
Files 657 657
Lines 190395 190395
Branches 36552 36553 +1
=======================================
+ Hits 168580 168587 +7
+ Misses 14993 14990 -3
+ Partials 6822 6818 -4 |
github-actions
bot
removed
the
request-ci
lpinca
force-pushed
the
deflake/test-watch-file-shared-dependency
branch
from
7e3ba67 to
8eb0df9
Compare
lpinca
force-pushed
the
deflake/test-watch-file-shared-dependency
branch
2 times, most recently
from
35a07c0 to
4b5f471
Compare
github-actions
bot
removed
the
request-ci
Delay dependency file modification on macOS. Refs: nodejs#51842
lpinca
force-pushed
the
deflake/test-watch-file-shared-dependency
branch
from
4b5f471 to
2fe6b2a
Compare
jakecastelli
approved these changes
Dec 23, 2024
jakecastelli
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in d00710d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay dependency file modification on macOS.
Refs: #51842