Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reserve NMV 133 for Electron 35 #56513

Merged
merged 1 commit into from
Jan 10, 2025
Merged

chore: reserve NMV 133 for Electron 35 #56513

merged 1 commit into from
Jan 10, 2025

Conversation

VerteDinde
Copy link
Contributor

This PR reserves NMV 133 for Electron 35

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 8, 2025
@VerteDinde VerteDinde mentioned this pull request Jan 8, 2025
Open
5 tasks
jakecastelli
jakecastelli approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@jakecastelli jakecastelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, could you change chore: to doc: to adhere to the commit message guideline

@jakecastelli jakecastelli added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 8, 2025
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 8, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 10, 2025
@nodejs-github-bot nodejs-github-bot merged commit 9be9348 into nodejs:main Jan 10, 2025
21 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 9be9348

targos pushed a commit that referenced this pull request Jan 13, 2025
@VerteDinde @targos
doc: reserve NMV 133 for Electron 35
bdf62d0 
PR-URL: #56513
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jan 13, 2025
@VerteDinde @Ceres6
doc: reserve NMV 133 for Electron 35
654baeb 
PR-URL: nodejs#56513
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakecastelli jakecastelli jakecastelli approved these changes

@richardlau richardlau richardlau approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@VerteDinde @nodejs-github-bot @lpinca @anonrig @richardlau @jakecastelli