Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor http-end-throw-socket-handling #5676

Closed
wants to merge 1 commit into from

Conversation

santigimeno
Copy link
Member

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

Affected core subsystem(s)

test

Description of change

Remove timer to avoid the test to timeout occasionally.

I have been getting this error on OS X:

=== release test-http-end-throw-socket-handling ===                            
Path: parallel/test-http-end-throw-socket-handling
/Users/sgimeno/node/node/test/parallel/test-http-end-throw-socket-handling.js:35
  throw new Error('Taking too long!');
  ^

Error: Taking too long!
    at ._onTimeout (/Users/sgimeno/node/node/test/parallel/test-http-end-throw-socket-handling.js:35:9)
    at Timer.unrefdHandle (timers.js:454:14)
Command: out/Release/node /Users/sgimeno/node/node/test/parallel/test-http-end-throw-socket-handling.js

Remove timer to avoid the test to timeout occasionally.
@claudiorodriguez claudiorodriguez added the test Issues and PRs related to the tests. label Mar 12, 2016
@claudiorodriguez
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/1909/
LGTM if CI is happy

@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Mar 12, 2016
@jasnell
Copy link
Member

jasnell commented Mar 12, 2016

LGTM

@claudiorodriguez
Copy link
Contributor

This one went under the radar. I'll be merging it in 24hs if no one objects.

claudiorodriguez pushed a commit that referenced this pull request Apr 2, 2016
Remove timer to avoid the test timing out occasionally.

PR-URL: #5676
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
@claudiorodriguez
Copy link
Contributor

Landed in 8d1d3bb

MylesBorins pushed a commit that referenced this pull request Apr 5, 2016
Remove timer to avoid the test timing out occasionally.

PR-URL: #5676
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
@MylesBorins
Copy link
Contributor

@jasnell lts?

@jasnell
Copy link
Member

jasnell commented Apr 21, 2016

+1
On Apr 20, 2016 11:30 PM, "Myles Borins" notifications@github.com wrote:

@jasnell https://github.com/jasnell lts?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#5676 (comment)

MylesBorins pushed a commit that referenced this pull request May 3, 2016
Remove timer to avoid the test timing out occasionally.

PR-URL: #5676
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
MylesBorins pushed a commit that referenced this pull request May 6, 2016
Remove timer to avoid the test timing out occasionally.

PR-URL: #5676
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
Remove timer to avoid the test timing out occasionally.

PR-URL: #5676
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
@MylesBorins MylesBorins mentioned this pull request May 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants