test: temporary remove resource check from fs read-write #56789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Since the last security release, the resource check has been flaky on Windows. This commit temporarily disables those checks to unblock the next regular release.
RafaelGSS
force-pushed
the
temporary-disable-resource
branch
from
defe5b3 to
c2633d9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56789 +/- ##
=======================================
Coverage 89.22% 89.22%
=======================================
Files 663 663
Lines 191974 191974
Branches 36926 36916 -10
=======================================
+ Hits 171286 171295 +9
+ Misses 13561 13558 -3
+ Partials 7127 7121 -6 |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
marco-ippolito
approved these changes
Jan 28, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Jan 28, 2025
marco-ippolito
added
the
commit-queue
Merged
nodejs-github-bot
removed
the
commit-queue
|
Landed in 55cc372 |
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 29, 2025
Since the last security release, the resource check has been flaky on Windows. This commit temporarily disables those checks to unblock the next regular release. PR-URL: #56789 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 2, 2025
Since the last security release, the resource check has been flaky on Windows. This commit temporarily disables those checks to unblock the next regular release. PR-URL: #56789 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marco-ippolito informed me some permission model tests are failing on Windows and until I get some time to find out why this is flaky on Windows (I have some guesses), let's disable those checks.
Refs: #56727 (comment)