Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix man pages link #5686 #5721

Closed
wants to merge 1 commit into from
Closed

docs: fix man pages link #5686 #5721

wants to merge 1 commit into from

Conversation

mithun-daa
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)
docs

Description of change

Please provide a description of the change here.
Add an extra check to make sure the tok type is not 'code before calling the linkManPages

@mithun-daa
docs: fix man pages link nodejs#5686
47394ab 
Do not call the linkManPages if the tok type is code
@Fishrock123 Fishrock123 added doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. labels Mar 15, 2016
@Fishrock123
Copy link
Contributor

lgtm if it works

cc @dcposch / @silverwind who landed 4e77a7c

Edit: sorry @dc, wrong person. :)

@jasnell
Copy link
Member

jasnell commented Mar 15, 2016

LGTM

@dcposch
Copy link
Contributor

dcposch commented Mar 15, 2016

looks reasonable to me

@Fishrock123
Copy link
Contributor

Linking: #5686

@mithun-daa
Copy link
Contributor Author

Just out of curiosity - what does the Its-watch-v4.x label mean? Is it ITS or LTS?

@MylesBorins
Copy link
Contributor

@mithun-daa lts-watch-v4.x means that we believe this commit should be backported to lts. When a PR has that label the commits that are landed are then audited for LTS. If they are merged into v4.x-staging then the label is changed to land-on-v4.x. Once they make it into a release the label is changed to landed-on-v4.x

If a PR or specific commits are deemed not suitable for LTS the label dont-land-on-v4.x is added.

We us a tool branch-diff which is able to utilize these labels and help us audit new changes that can be landed on LTS

jasnell pushed a commit that referenced this pull request Mar 16, 2016
@mithun-daa @jasnell
docs: fix man pages link if tok type is code
e6bdb61 
Do not call the linkManPages if the tok type is code

Fixes: #5686
PR-URL: #5721
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 16, 2016

Landed in e6bdb61

@jasnell jasnell closed this Mar 16, 2016
@jasnell
Copy link
Member

jasnell commented Mar 16, 2016

@mithun-daa ... I did update the commit log to fit our commit guidelines standards.

MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
@mithun-daa
docs: fix man pages link if tok type is code
651ac2c 
Do not call the linkManPages if the tok type is code

Fixes: #5686
PR-URL: #5721
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@mithun-daa
docs: fix man pages link if tok type is code
7b7fb6b 
Do not call the linkManPages if the tok type is code

Fixes: #5686
PR-URL: #5721
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@mithun-daa
docs: fix man pages link if tok type is code
2053995 
Do not call the linkManPages if the tok type is code

Fixes: #5686
PR-URL: #5721
Reviewed-By: James M Snell <jasnell@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Mar 22, 2016
Merged
Fishrock123 pushed a commit that referenced this pull request Mar 22, 2016
@mithun-daa @Fishrock123
docs: fix man pages link if tok type is code
f34a00c 
Do not call the linkManPages if the tok type is code

Fixes: #5686
PR-URL: #5721
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mithun-daa @Fishrock123 @jasnell @dcposch @MylesBorins