Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update AUTHORS list #582

Merged
merged 2 commits into from
Jan 24, 2015
Merged

doc: update AUTHORS list #582

merged 2 commits into from
Jan 24, 2015

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jan 23, 2015

last time was 8cf6079 @ Jan-16

I'm also removing tools/updateAuthors.awk, Ryan's original script for this, separate commit

@bnoordhuis
Copy link
Member

LGTM

@rvagg
Copy link
Member Author

rvagg commented Jan 23, 2015

We're getting a few @users.noreply.github.com addresses in here, does anyone have an opinion on whether this is a problem? Also there's some non-real name entries too, if those users want to fix their details then please do in the .mailmap file.

@bnoordhuis
Copy link
Member

I've seen it (I merged some of those PRs). I personally don't find it really objectionable but if someone else does, we can start enforcing real email addresses from now on.

Update AUTHORS file using tools/update-authors.sh

PR-URL: nodejs#582
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Using the new tools/update-authors.sh script so this is
redundant

PR-URL: nodejs#582
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@rvagg rvagg merged commit 73ddaa6 into nodejs:v1.x Jan 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants