gyp: add missing openssl_fips% to common.gypi
#5919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No comments, it just should be there in some rare cases. See: atom/node@cba512d
|
cc @zcbenz |
|
cc @nodejs/collaborators |
|
Perhaps the commit description should target the |
|
LGTM. Agree with @mscdex, plus perhaps remove the 'no comment' reference since you link to an example of the problem. |
|
Looks good to me, thanks! |
|
Landed in 26a4a4b, thank you everyone! |
indutny
added a commit
that referenced
this pull request
Mar 27, 2016
See: atom/node@cba512d PR-URL: #5919 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
evanlucas
pushed a commit
that referenced
this pull request
Mar 30, 2016
See: atom/node@cba512d PR-URL: #5919 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
|
@indutny should this be backported to lts? |
|
I would say go for it! 😉 |
evanlucas
pushed a commit
that referenced
this pull request
Mar 31, 2016
See: atom/node@cba512d PR-URL: #5919 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 11, 2016
See: atom/node@cba512d PR-URL: #5919 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Affected core subsystem(s)
gyp
Description of change
No comments, it just should be there in some rare cases.
See: atom/node@cba512d