tools: remove obsolete lint config file #5959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All JS files have been moved out of the `src` directory so the `.eslintrc` file in that directory can also be removed.
Trott
added
tools
|
LGTM |
|
lgtm |
|
LGTM |
|
Can't imagine how this could negatively impact CI, but... https://ci.nodejs.org/job/node-test-pull-request/2117/ |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 1, 2016
All JS files have been moved out of the `src` directory so the `.eslintrc` file in that directory can also be removed. PR-URL: nodejs#5959 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Klauke <romankl@users.noreply.github.com>
|
Landed in f1fc698 |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 5, 2016
All JS files have been moved out of the `src` directory so the `.eslintrc` file in that directory can also be removed. PR-URL: #5959 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Klauke <romankl@users.noreply.github.com>
This was referenced Apr 5, 2016
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
Affected core subsystem(s)
tools, src
Description of change
All JS files have been moved out of the
srcdirectory so the.eslintrcfile in that directory can also be removed.