Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: minor argument formatting in stream.markdown #6016

Closed
wants to merge 1 commit into from
Closed

doc: minor argument formatting in stream.markdown #6016

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Apr 2, 2016

Pull Request check-list

  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

Affected core subsystem(s)

doc

Description of change

Minor argument formatting fix.

Fixes: #4350

@jasnell jasnell added the doc Issues and PRs related to the documentations. label Apr 2, 2016
@jasnell
Copy link
Member Author

jasnell commented Apr 2, 2016

@nodejs/documentation

@Trott
Copy link
Member

Trott commented Apr 2, 2016

LGTM

3 similar comments
@thefourtheye
Copy link
Contributor

LGTM

@r-52
Copy link
Contributor

r-52 commented Apr 2, 2016

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Apr 2, 2016

LGTM

@mscdex mscdex added the stream Issues and PRs related to the stream subsystem. label Apr 2, 2016
jasnell added a commit that referenced this pull request Apr 2, 2016
@jasnell
doc: minor argument formatting in stream.markdown
63e743d 
Fixes: #4350
PR-URL: #6016
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Apr 2, 2016

Landed in 63e743d

@jasnell jasnell closed this Apr 2, 2016
MylesBorins pushed a commit that referenced this pull request Apr 5, 2016
@jasnell
doc: minor argument formatting in stream.markdown
7337ef6 
Fixes: #4350
PR-URL: #6016
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Apr 5, 2016
Closed
Merged
Closed
@MylesBorins
Copy link
Contributor

@jasnell lts?

MylesBorins pushed a commit that referenced this pull request May 3, 2016
@jasnell
doc: minor argument formatting in stream.markdown
4b8e2bd 
Fixes: #4350
PR-URL: #6016
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 6, 2016
@jasnell
doc: minor argument formatting in stream.markdown
06caef0 
Fixes: #4350
PR-URL: #6016
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
@jasnell
doc: minor argument formatting in stream.markdown
6d56009 
Fixes: #4350
PR-URL: #6016
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 18, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Documentation - Change style of parameter type
7 participants
@jasnell @Trott @thefourtheye @r-52 @cjihrig @MylesBorins @mscdex