doc: note about Android support #6040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
doc
Trott
force-pushed
the
not-supported
branch
2 times, most recently
from
f5d36fc
to
7a2c3bd
Compare
| ### Android / Android-based devices (e.g., Firefox OS) | ||
|
|
||
| Although these instructions for building on Android are provided, please note | ||
| that Android is not a supported platform at this time. Patches to improve |
There was a problem hiding this comment.
This is a small nit, but perhaps it should say is not an officially supported platform?
There was a problem hiding this comment.
@mscdex I agree with your nit. Updating now...
|
LGTM |
1 similar comment
|
LGTM |
|
LGTM |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 6, 2016
PR-URL: nodejs#6040 Refs: nodejs#6035 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
|
Landed in 0f3c3b4 |
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Affected core subsystem(s)
doc build arm
Description of change
Android is not supported at this time, so let's make sure people know that before they get too far.
Refs: #6035