src,tools: rewrite check-imports and fix linter errors

Makefile

@@ -630,6 +630,7 @@ CPPLINT_FILES = $(filter-out $(CPPLINT_EXCLUDE), $(wildcard \
 
 cpplint:
 	@$(PYTHON) tools/cpplint.py $(CPPLINT_FILES)
+	@$(PYTHON) tools/check-imports.py
 
 ifneq ("","$(wildcard tools/eslint/bin/eslint.js)")
 lint: jslint cpplint

src/async-wrap.cc

@@ -8,7 +8,6 @@
 #include "v8.h"
 #include "v8-profiler.h"
 
-using v8::Array;
 using v8::Boolean;
 using v8::Context;
 using v8::Function;

src/env.cc

@@ -17,7 +17,6 @@ using v8::Local;
 using v8::Message;
 using v8::StackFrame;
 using v8::StackTrace;
-using v8::TryCatch;
 using v8::Value;
 
 void Environment::PrintSyncTrace() const {

src/handle_wrap.cc

@@ -9,7 +9,6 @@
 
 namespace node {
 
-using v8::Boolean;
 using v8::Context;
 using v8::FunctionCallbackInfo;
 using v8::HandleScope;

src/node.cc

@@ -127,8 +127,6 @@ using v8::PromiseRejectMessage;
 using v8::PropertyCallbackInfo;
 using v8::ScriptOrigin;
 using v8::SealHandleScope;
-using v8::StackFrame;
-using v8::StackTrace;
 using v8::String;
 using v8::TryCatch;
 using v8::Uint32;

src/node_buffer.cc

@@ -71,7 +71,6 @@ using v8::Context;
 using v8::EscapableHandleScope;
 using v8::Function;
 using v8::FunctionCallbackInfo;
-using v8::FunctionTemplate;
 using v8::HandleScope;
 using v8::Integer;
 using v8::Isolate;

src/node_contextify.cc

@@ -11,7 +11,6 @@
 
 namespace node {
 
-using v8::AccessType;
 using v8::Array;
 using v8::ArrayBuffer;
 using v8::Boolean;
@@ -30,7 +29,6 @@ using v8::Maybe;
 using v8::MaybeLocal;
 using v8::Name;
 using v8::NamedPropertyHandlerConfiguration;
-using v8::None;
 using v8::Object;
 using v8::ObjectTemplate;
 using v8::Persistent;

src/node_v8.cc

@@ -20,7 +20,6 @@ using v8::NewStringType;
 using v8::Object;
 using v8::String;
 using v8::Uint32;
-using v8::Uint32Array;
 using v8::V8;
 using v8::Value;
 

src/node_watchdog.cc

@@ -4,9 +4,6 @@
 
 namespace node {
 
-using v8::V8;
-
-
 Watchdog::Watchdog(v8::Isolate* isolate, uint64_t ms) : isolate_(isolate),
                                                         destroyed_(false) {
   int rc;

src/pipe_wrap.cc

@@ -26,7 +26,6 @@ using v8::HandleScope;
 using v8::Integer;
 using v8::Local;
 using v8::Object;
-using v8::PropertyAttribute;
 using v8::String;
 using v8::Undefined;
 using v8::Value;

src/stream_wrap.cc

@@ -22,20 +22,15 @@
 
 namespace node {
 
-using v8::Array;
 using v8::Context;
 using v8::EscapableHandleScope;
 using v8::FunctionCallbackInfo;
 using v8::FunctionTemplate;
 using v8::HandleScope;
 using v8::Integer;
 using v8::Local;
-using v8::Number;
 using v8::Object;
-using v8::PropertyCallbackInfo;
-using v8::String;
 using v8::True;
-using v8::Undefined;
 using v8::Value;
 
 

src/string_bytes.cc

@@ -19,10 +19,10 @@ using v8::EscapableHandleScope;
 using v8::HandleScope;
 using v8::Isolate;
 using v8::Local;
+using v8::MaybeLocal;
 using v8::Object;
 using v8::String;
 using v8::Value;
-using v8::MaybeLocal;
 
 template <typename ResourceType, typename TypeName>
 class ExternString: public ResourceType {

src/tcp_wrap.cc

@@ -27,7 +27,6 @@ using v8::HandleScope;
 using v8::Integer;
 using v8::Local;
 using v8::Object;
-using v8::PropertyAttribute;
 using v8::String;
 using v8::Undefined;
 using v8::Value;

src/tls_wrap.cc

@@ -15,18 +15,16 @@
 
 namespace node {
 
-using crypto::SSLWrap;
 using crypto::SecureContext;
+using crypto::SSLWrap;
 using v8::Boolean;
 using v8::Context;
 using v8::EscapableHandleScope;
 using v8::Exception;
 using v8::Function;
 using v8::FunctionCallbackInfo;
 using v8::FunctionTemplate;
-using v8::Integer;
 using v8::Local;
-using v8::Null;
 using v8::Object;
 using v8::String;
 using v8::Value;

src/tty_wrap.cc

@@ -21,7 +21,6 @@ using v8::FunctionTemplate;
 using v8::Integer;
 using v8::Local;
 using v8::Object;
-using v8::PropertyAttribute;
 using v8::String;
 using v8::Value;
 

src/util.cc

@@ -6,8 +6,8 @@
 namespace node {
 
 using v8::Isolate;
-using v8::String;
 using v8::Local;
+using v8::String;
 using v8::Value;
 
 static int MakeUtf8String(Isolate* isolate,

src/uv.cc

@@ -9,8 +9,8 @@ namespace uv {
 using v8::Context;
 using v8::FunctionCallbackInfo;
 using v8::FunctionTemplate;
-using v8::Local;
 using v8::Integer;
+using v8::Local;
 using v8::Object;
 using v8::String;
 using v8::Value;

tools/check-imports.py

@@ -0,0 +1,42 @@
+#!/usr/bin/env python
+
+from __future__ import print_function
+import glob
+import re
+import sys
+
+
+def do_exist(file_name, lines, imported):
+  if not any(not re.match('using \w+::{0};'.format(imported), line) and
+             re.search(imported, line) for line in lines):
+    print('File "{0}" does not use "{1}"'.format(file_name, imported))
+    return False
+  return True
+
+
+def is_valid(file_name):
+  with open(file_name) as source_file:
+    lines = [line.strip() for line in source_file]
+
+  usings, importeds, line_numbers, valid = [], [], [], True
+  for idx, line in enumerate(lines, 1):
+    matches = re.search(r'^using (\w+::(\w+));$', line)
+    if matches:
+      line_numbers.append(idx)
+      usings.append(matches.group(1))
+      importeds.append(matches.group(2))
+
+  valid = all([do_exist(file_name, lines, imported) for imported in importeds])
+
+  sorted_usings = sorted(usings, key=lambda x: x.lower())
+  if sorted_usings != usings:
+    print("using statements aren't sorted in '{0}'.".format(file))
+    for num, actual, expected in zip(line_numbers, usings, sorted_usings):
+      if actual != expected:
+        print('\tLine {0}: Actual: {1}, Expected: {2}'
+            .format(num, actual, expected))
+    return False
+  else:
+    return valid
+
+sys.exit(0 if all(map(is_valid, glob.iglob('src/*.cc'))) else 1)