benchmarks: add microbenchmarks for new ES6 features #6222

jasnell · 2016-04-15T16:35:15Z

Checklist

tests and code linting passes
a test and/or benchmark is included
the commit message follows commit guidelines

Affected core subsystem(s)

benchmarks

Description of change

Adds new microbenchmarks for destructuring, rest params and default params.

Now that v8 v5 has landed, it makes sense to track the perf of various new language features. These are very simple raw micro-benchmarks.

Current results from master:

bash-3.2$ ./node benchmark/misc/restparams-bench.js 
misc/restparams-bench.js method=old millions=100: 11.42148
misc/restparams-bench.js method=new millions=100: 23.56694
misc/restparams-bench.js method=arguments millions=100: 14.49330

bash-3.2$ ./node benchmark/misc/defaultparams-bench.js 
misc/defaultparams-bench.js method=old millions=100: 26.88026
misc/defaultparams-bench.js method=new millions=100: 25.99777

bash-3.2$ ./node benchmark/misc/destructuring-bench.js 
misc/destructuring-bench.js method=old millions=100: 2230.47279
misc/destructuring-bench.js method=new millions=100: 15.22549
bash-3.2$

( Note how much slower the new destructuring assignment is for a simple var swap :-/ )

jasnell · 2016-04-15T16:36:16Z

@nodejs/benchmarking

mscdex · 2016-04-15T16:42:04Z

I feel like these kinds of benchmarks should have their own, specific subdirectory rather than living in misc/.

mscdex · 2016-04-15T16:42:57Z

benchmark/misc/restparams-bench.js

+  var i = 0;
+  bench.start();
+  for (; i < n; i++)
+    b(1, 2, 'a', 'b');


This should be calling c(), not b().

ha! stupid cut n paste errors

Also, I think a(), b(), and c() should be renamed to something more descriptive.

mscdex · 2016-04-15T16:49:23Z

benchmark/misc/destructuring-bench.js

+  bench.end(n / 1e6);
+}
+
+function runSwapNew(n) {


Perhaps this should be named something like runSwapDestructure or something and the other one like runSwapManual.

jasnell · 2016-04-15T17:06:01Z

@mscdex ... done! benchmarks moved to a separate dir

mscdex · 2016-04-15T20:16:07Z

benchmark/es/restparams-bench.js

+      runUseArguments(n);
+      break;
+    default:
+      throw new Error('Unexpected');


s/Unexpected/Unexpected method/

Same for the other benchmark files.

It's useful to be able to force optimization of a function. Rather than duplicating the code everywhere for it, let's make a utility available.

Adds new microbenchmarks for destructuring, rest params and default params.

jasnell · 2016-04-15T20:58:04Z

@mscdex ... done. Also, I moved the v8 force optimization code out to a utility function so it can be easily reused.

mscdex · 2016-04-15T21:00:30Z

I'm not enough of a v8 expert to know if moving the forced optimization out to a separate function changes behavior at all or not (optimizing via a var/let/const variable vs a function parameter variable?).

jasnell · 2016-04-15T21:06:03Z

running a few tests it did not appear to change the behavior at all.

jasnell · 2016-04-15T21:10:23Z

@vkurchatkin ... any insights?

mscdex · 2016-04-15T23:41:29Z

lint: https://ci.nodejs.org/job/node-test-linter/2066/

jasnell · 2016-04-20T19:04:45Z

mscdex... LGTY?

jasnell · 2016-04-20T19:05:23Z

running tests on the optimization code here and it does not appear that there is any difference in how it optimizes when called like this... at least no obvious difference

mscdex · 2016-04-20T20:31:34Z

LGTM then

It's useful to be able to force optimization of a function. Rather than duplicating the code everywhere for it, let's make a utility available. PR-URL: #6222 Reviewed-By: Brian White <mscdex@mscdex.net>

Adds new microbenchmarks for destructuring, rest params and default params. PR-URL: #6222 Reviewed-By: Brian White <mscdex@mscdex.net>

jasnell · 2016-04-20T21:58:59Z

Landed in cb9eff2 and 7dc1a87

It's useful to be able to force optimization of a function. Rather than duplicating the code everywhere for it, let's make a utility available. PR-URL: nodejs#6222 Reviewed-By: Brian White <mscdex@mscdex.net>

Adds new microbenchmarks for destructuring, rest params and default params. PR-URL: nodejs#6222 Reviewed-By: Brian White <mscdex@mscdex.net>

It's useful to be able to force optimization of a function. Rather than duplicating the code everywhere for it, let's make a utility available. PR-URL: #6222 Reviewed-By: Brian White <mscdex@mscdex.net>

Adds new microbenchmarks for destructuring, rest params and default params. PR-URL: #6222 Reviewed-By: Brian White <mscdex@mscdex.net>

jasnell added the benchmark Issues and PRs related to the benchmark subsystem. label Apr 15, 2016

jasnell force-pushed the esfeature-benchmarks branch from cc2bc39 to 91bd204 Compare April 15, 2016 16:35

mscdex reviewed Apr 15, 2016
View reviewed changes

jasnell force-pushed the esfeature-benchmarks branch from 91bd204 to 55e546a Compare April 15, 2016 16:48

mscdex reviewed Apr 15, 2016
View reviewed changes

jasnell force-pushed the esfeature-benchmarks branch from 55e546a to 6d5058e Compare April 15, 2016 16:56

mscdex reviewed Apr 15, 2016
View reviewed changes

jasnell added 2 commits April 15, 2016 13:56

benchmarks: add common.v8ForceOptimization

afe8857

It's useful to be able to force optimization of a function. Rather than duplicating the code everywhere for it, let's make a utility available.

benchmarks: add microbenchmarks for new ES6 features

5071349

Adds new microbenchmarks for destructuring, rest params and default params.

jasnell force-pushed the esfeature-benchmarks branch from f5b3d1e to 5071349 Compare April 15, 2016 20:57

jasnell added a commit that referenced this pull request Apr 20, 2016

benchmarks: add microbenchmarks for new ES6 features

7dc1a87

Adds new microbenchmarks for destructuring, rest params and default params. PR-URL: #6222 Reviewed-By: Brian White <mscdex@mscdex.net>

jasnell added dont-land-on-v5.x labels Apr 20, 2016

jasnell closed this Apr 20, 2016

jasnell added a commit that referenced this pull request Apr 26, 2016

benchmarks: add microbenchmarks for new ES6 features

451f4fc

Adds new microbenchmarks for destructuring, rest params and default params. PR-URL: #6222 Reviewed-By: Brian White <mscdex@mscdex.net>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

benchmarks: add microbenchmarks for new ES6 features #6222

benchmarks: add microbenchmarks for new ES6 features #6222

jasnell commented Apr 15, 2016 •

edited

Loading

jasnell commented Apr 15, 2016

mscdex commented Apr 15, 2016

mscdex Apr 15, 2016

jasnell Apr 15, 2016

mscdex Apr 15, 2016

jasnell Apr 15, 2016

mscdex Apr 15, 2016

jasnell Apr 15, 2016

jasnell commented Apr 15, 2016

mscdex Apr 15, 2016 •

edited

Loading

jasnell commented Apr 15, 2016

mscdex commented Apr 15, 2016

jasnell commented Apr 15, 2016

jasnell commented Apr 15, 2016

mscdex commented Apr 15, 2016

jasnell commented Apr 20, 2016

jasnell commented Apr 20, 2016

mscdex commented Apr 20, 2016

jasnell commented Apr 20, 2016

benchmarks: add microbenchmarks for new ES6 features #6222

benchmarks: add microbenchmarks for new ES6 features #6222

Conversation

jasnell commented Apr 15, 2016 • edited Loading

Checklist

Affected core subsystem(s)

Description of change

jasnell commented Apr 15, 2016

mscdex commented Apr 15, 2016

mscdex Apr 15, 2016

Choose a reason for hiding this comment

jasnell Apr 15, 2016

Choose a reason for hiding this comment

mscdex Apr 15, 2016

Choose a reason for hiding this comment

jasnell Apr 15, 2016

Choose a reason for hiding this comment

mscdex Apr 15, 2016

Choose a reason for hiding this comment

jasnell Apr 15, 2016

Choose a reason for hiding this comment

jasnell commented Apr 15, 2016

mscdex Apr 15, 2016 • edited Loading

Choose a reason for hiding this comment

jasnell commented Apr 15, 2016

mscdex commented Apr 15, 2016

jasnell commented Apr 15, 2016

jasnell commented Apr 15, 2016

mscdex commented Apr 15, 2016

jasnell commented Apr 20, 2016

jasnell commented Apr 20, 2016

mscdex commented Apr 20, 2016

jasnell commented Apr 20, 2016

jasnell commented Apr 15, 2016 •

edited

Loading

mscdex Apr 15, 2016 •

edited

Loading