tools: enable linting for v8_prof_processor.js #6262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`lib/internal/v8_prof_processor.js` was being excluded from linting, but the only lint issue it has is that it cannot run in strict mode. Disable the `strict` rule with a comment and remove the file from `.eslintignore`.
Trott
added
v8 engine
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Apr 20, 2016
`lib/internal/v8_prof_processor.js` was being excluded from linting, but the only lint issue it has is that it cannot run in strict mode. Disable the `strict` rule with a comment and remove the file from `.eslintignore`. PR-URL: #6262 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 4bbd418 |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
`lib/internal/v8_prof_processor.js` was being excluded from linting, but the only lint issue it has is that it cannot run in strict mode. Disable the `strict` rule with a comment and remove the file from `.eslintignore`. PR-URL: #6262 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 21, 2016
`lib/internal/v8_prof_processor.js` was being excluded from linting, but the only lint issue it has is that it cannot run in strict mode. Disable the `strict` rule with a comment and remove the file from `.eslintignore`. PR-URL: #6262 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
Apr 25, 2016
`lib/internal/v8_prof_processor.js` was being excluded from linting, but the only lint issue it has is that it cannot run in strict mode. Disable the `strict` rule with a comment and remove the file from `.eslintignore`. PR-URL: nodejs#6262 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 26, 2016
`lib/internal/v8_prof_processor.js` was being excluded from linting, but the only lint issue it has is that it cannot run in strict mode. Disable the `strict` rule with a comment and remove the file from `.eslintignore`. PR-URL: #6262 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 17, 2016
`lib/internal/v8_prof_processor.js` was being excluded from linting, but the only lint issue it has is that it cannot run in strict mode. Disable the `strict` rule with a comment and remove the file from `.eslintignore`. PR-URL: #6262 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2016
`lib/internal/v8_prof_processor.js` was being excluded from linting, but the only lint issue it has is that it cannot run in strict mode. Disable the `strict` rule with a comment and remove the file from `.eslintignore`. PR-URL: #6262 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
tools v8
Description of change
lib/internal/v8_prof_processor.jswas being excluded from linting, butthe only lint issue it has is that it cannot run in strict mode. Disable
the
strictrule with a comment and remove the file from.eslintignore.